Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mf adding global color and micel styling #74

Closed
wants to merge 6 commits into from

Conversation

krsnamara
Copy link
Collaborator

Description

Adds global style variables for color. Also adds a google font to the available list of font-family.

I added some styling to the List-Items to manage the space and information differently.
Also a conditional render of the sorted item categories if there are no items in that category.

This is a draft PR to show some suggestions.

Related Issue

Acceptance Criteria

Type of Changes

Use one or more labels to help your team understand the nature of the change(s) you’re proposing. E.g., bug fix or enhancement are common ones.

Updates

Before

After

Testing Steps / QA Criteria

@krsnamara krsnamara added enhancement New feature or request refactoring suggestion a suggestion for a new issue design sprint design sprint from issue 14 labels Mar 29, 2024
@krsnamara krsnamara self-assigned this Mar 29, 2024
Copy link

Visit the preview URL for this PR (updated for commit 56dab3e):

https://tcl-69-smart-shopping-list--pr74-mf-adding-global-col-cd2iezqm.web.app

(expires Fri, 05 Apr 2024 19:09:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 93172cc46147b7d365c2b1b8239b61e2efb07a80

@krsnamara
Copy link
Collaborator Author

Going to close this as we have moved in a different direction. This is the latest coding for the app with the sticky 'add' item button on the right and the list items organization is to the left.

@krsnamara krsnamara closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design sprint design sprint from issue 14 enhancement New feature or request refactoring suggestion a suggestion for a new issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant