Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Navlink element #17

Merged
merged 1 commit into from
Feb 8, 2024
Merged

add Navlink element #17

merged 1 commit into from
Feb 8, 2024

Conversation

vivitt
Copy link
Collaborator

@vivitt vivitt commented Feb 5, 2024

For an example of how to fill this template out, see this Pull Request.

Description

Add and use the NavLink element in the Layout component

Related Issue

closes #3

Acceptance Criteria

[ x ] The nav element is added to the Layout component
[ x ] Links to the "Home", "List", and "Add item" pages of the app are In the nav element
[ x ] The links all function as expected using the NavLink component from react-router-dom

Type of Changes

Feature

Updates

Before

Screen.Recording.2024-02-05.at.12.55.05.mov

After

Screen.Recording.2024-02-05.at.12.54.16.mov

Testing Steps / QA Criteria

  • git pull origin bm-vy-link-nav
  • navigate from /home to /list and to /manage-list using the NavLink component

Copy link

github-actions bot commented Feb 5, 2024

Visit the preview URL for this PR (updated for commit 9cbb328):

https://tcl-71-smart-shopping-list--pr17-bm-vy-link-nav-cmf9k461.web.app

(expires Mon, 12 Feb 2024 11:58:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1e7ade9d0f374c4ddb5d7ab6fc541062fc7a1ab4

Copy link
Collaborator

@ocsiddisco ocsiddisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Collaborator

@BikeMouse BikeMouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Copy link
Collaborator

@Amaka202 Amaka202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job team!!!💥💥💥

Your feature works well and your code is good!

@vivitt vivitt merged commit 03a0bc4 into main Feb 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants