Jk vy share list

[BikeMouse]

Description

Implemented the "sharing list with another user by email" functionality

Related Issue

closes #6

Acceptance Criteria

•  The ManageList view shows a form that allows the user to enter an email to invite an existing user to a list, in addition to the form that allows them to add items to that list.
•  The input that accepts the email has a semantic label element associated with it
•  The user can submit this form with both the mouse and the Enter key
•  If the other user exists, the user is alerted that the list was shared
•  If the other user does not exist, the user is shown an error message that explains the problem

Type of Changes

adding feature

Updates

Before

After

Testing Steps / QA Criteria

git checkout jk--vy--share-list
git pull
npm start
go to manage list
provide email

[github-actions]

Visit the preview URL for this PR (updated for commit db38b74):

https://tcl-71-smart-shopping-list--pr23-jk-vy-share-list-n4z44xgo.web.app

_{(expires Tue, 27 Feb 2024 12:27:21 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 1e7ade9d0f374c4ddb5d7ab6fc541062fc7a1ab4}

[ocsiddisco]

Nicely done! I like the checking for an empty user input!
Something that is not in the requirement, but could be a nice add: checking if the user is not assigning their own email address.

[elitcenk]

It looks good. Well done.

[BikeMouse]

@ocsiddisco Do you mean if I put my own email I get a message saying "You put in your own email?"

[borjaMarti]

Tested locally and works as expected, nice job!! 💪

[vivitt]

I noticed that in our implementation, a user is only able to share a list if they are the owner of that list. I wonder if this is the expected behavior in the app, or if we might be missing some work to allow every user in the list to share it with others.

I created a new-test-list and shared it with all team members in case anyone wants to test it.

[BikeMouse]

I could imagine that is the expected behaviour tbh. In fact, picturing myself using this app, I wouldn't want a random user to share my list

[vivitt]

I could imagine that is the expected behaviour tbh. In fact, picturing myself using this app, I wouldn't want a random user to share my list

Yes, I guess so... I was unsure about this since I tested the feature with test-list which it is also within my lists but was created by other user and wasn't able to share it.