Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #14.3: Create <IconButton> Component #35

Merged
merged 6 commits into from
Sep 28, 2024
Merged

Conversation

dterceroparker
Copy link
Member

@dterceroparker dterceroparker commented Sep 26, 2024

Description

This PR addresses the creation of an IconButton component as outlined in the tlined in the wireframe. The component includes a button that contains an icon and a label text. We imported fontAwesome into project (please reference index.html file).

Related Issue

Closes #34

Acceptance Criteria

  • <IconButton> renders a real element.
  • <IconButton> accepts props that allow it to render any combination of icon and label text (see notes section).
  • Label text, if present, is placed visually below the icon.

Type of Changes

Enhancement

Updates

After

screenshot_2024-09-26_at_3 26 20___pm_720

Testing Steps / QA Criteria

  • Log in using Google credentials
  • Refer to NavBar
  • Click on links to ensure navigation and styling changes.

Note: Signout link currently navigates to View Lists because we have not yet created a Landing Page.

Copy link

github-actions bot commented Sep 26, 2024

Visit the preview URL for this PR (updated for commit ea081ad):

https://tcl-74-smart-shopping-list--pr35-nr-dtp-iconbutton-h2d8s5p3.web.app

(expires Sat, 05 Oct 2024 16:39:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 79d73546692f99aad8468c28e36db434e2c190ac

… reflect wireframe (add item, view lists, sign out), update update Layout.css for active NavLinks
@dterceroparker dterceroparker added the enhancement New feature or request label Sep 26, 2024
@dterceroparker dterceroparker marked this pull request as ready for review September 26, 2024 19:31
Copy link
Collaborator

@shuveksha-tuladhar shuveksha-tuladhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great! The View List and Add Items buttons are functioning as expected. Thank you.

Copy link
Contributor

@stacy-tech stacy-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dterceroparker dterceroparker merged commit a3596ce into main Sep 28, 2024
2 checks passed
@dterceroparker dterceroparker deleted the nr-dtp-iconbutton branch September 28, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

14.3 Create <IconButton> component
4 participants