Add table tab and add image #2957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barshathakuri
force-pushed
the
feature/add-data-tables-tab
branch
2 times, most recently
from
051e309
to
d7381f6
Compare
subinasr
requested changes
Jun 13, 2024
subinasr
force-pushed
the
feature/add-data-tables-tab
branch
from
d7381f6
to
8c26bfd
Compare
barshathakuri
force-pushed
the
feature/add-data-tables-tab
branch
5 times, most recently
from
6301d76
to
83c05d8
Compare
AdityaKhatri
previously requested changes
Jun 18, 2024
subinasr
reviewed
Jun 18, 2024
subinasr
force-pushed
the
feature/add-data-tables-tab
branch
from
b77cfc2
to
65cd265
Compare
subinasr
reviewed
Jun 18, 2024
subinasr
reviewed
Jun 18, 2024
subinasr
force-pushed
the
feature/add-data-tables-tab
branch
4 times, most recently
from
6e4e5b3
to
5fa40dd
Compare
tnagorra
approved these changes
Jun 21, 2024
subinasr
force-pushed
the
feature/add-data-tables-tab
branch
from
c6b046d
to
d313852
Compare
frozenhelium
requested changes
Jun 26, 2024
| > | ||
| <ImagePreview | ||
| alt="Preview Image" | ||
| src={attachment.filePreview?.url ?? ''} |
There was a problem hiding this comment.
Don't use empty string as default value
subinasr
force-pushed
the
feature/add-data-tables-tab
branch
from
d313852
to
6c02e6c
Compare
subinasr
force-pushed
the
feature/add-data-tables-tab
branch
2 times, most recently
from
49b505e
to
6c1e136
Compare
tnagorra
reviewed
Jun 27, 2024
tnagorra
reviewed
Jun 27, 2024
tnagorra
reviewed
Jun 27, 2024
tnagorra
previously requested changes
Jun 28, 2024
| ] = useState<boolean>(false); | ||
|
|
||
| const leadAttachmentIdsWithEntries = useMemo(() => ( | ||
| Object.values(entryAttachmentsMap ?? {}) |
There was a problem hiding this comment.
Suggested change
| Object.values(entryAttachmentsMap ?? {}) | |
| Object.values(entryAttachmentsMap) |
subinasr
force-pushed
the
feature/add-data-tables-tab
branch
from
6c1e136
to
35b17c4
Compare
frozenhelium
approved these changes
Jul 5, 2024
subinasr
approved these changes
Jul 5, 2024
- Fix styling for the added tab 'Tables and Visuals'
subinasr
force-pushed
the
feature/add-data-tables-tab
branch
from
e1994d5
to
0cfa4b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR doesn't introduce any:
console.logmeant for debuggingThis PR contains valid: