Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/summary score cna #1324

Merged
merged 34 commits into from
Aug 17, 2023
Merged

Feature/summary score cna #1324

merged 34 commits into from
Aug 17, 2023

Conversation

Rup-Narayan-Rajbanshi
Copy link
Contributor

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi commented Jun 13, 2023 •
edited
Loading

Changes

  • Add Mutation and query for:
    - Score
    - Cna
    - Summary
  • Add Test Case

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi marked this pull request as draft June 13, 2023 09:59
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/summary-score-cna branch 11 times, most recently from 98bb495 to 085947b Compare June 15, 2023 11:39
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi marked this pull request as ready for review June 16, 2023 04:25
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/summary-score-cna branch 3 times, most recently from 3ec5da2 to 0cfd6f0 Compare June 19, 2023 09:06
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/summary-score-cna branch 3 times, most recently from 706b6c6 to ceeb9ee Compare July 4, 2023 06:11
@thenav56 thenav56 force-pushed the project/assessment-registry branch from 4d52a6a to cc264e8 Compare July 10, 2023 05:08
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi mentioned this pull request Jul 10, 2023
Merged
9 tasks
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/summary-score-cna branch 4 times, most recently from c2f1471 to b0a41b4 Compare July 25, 2023 10:33
@Rup-Narayan-Rajbanshi @thenav56
Add models for summary tab
973f39c
@Rup-Narayan-Rajbanshi @thenav56
Add mutation and schema for summary tab
9031ab3
@Rup-Narayan-Rajbanshi @thenav56
Add Mutation for Issue
4ac8904
@Rup-Narayan-Rajbanshi @thenav56
Add query and filter for summary issue
2c3917d
@Rup-Narayan-Rajbanshi @thenav56
Add endpoint for Summary sector subsector
469db98
@Rup-Narayan-Rajbanshi @thenav56
Add mutation for rest of the tabs.
8a555ac
@thenav56
Add summary focus options in the summary_focus_options query
99fe72a
@thenav56
Add test for summary mutation
ba38078
@thenav56
Add test case for summary query
363e2e9
@thenav56
Add LeadDetalType in AssessmentRegistrytype
1ff7e6d
@Rup-Narayan-Rajbanshi @thenav56
Modify validation for score_rating and score_analytical_density
b7e35f8
@Rup-Narayan-Rajbanshi @thenav56
Add enums to score dimmensions.
c6326ec
@Rup-Narayan-Rajbanshi @thenav56
Add NonNull to the list field in assessment_registry query.
35334af
@Rup-Narayan-Rajbanshi @thenav56
Add score options in assessment_registry_options query
dbbef22
@Rup-Narayan-Rajbanshi @thenav56
Make the score options response into flat.
223e234
@Rup-Narayan-Rajbanshi @thenav56
Change name convention in for Summary Tab's element.
700be80
@Rup-Narayan-Rajbanshi @thenav56
Add id for all nested objects for update mutation.
86e6726
@Rup-Narayan-Rajbanshi @thenav56
Modify the summary_options query to get flat response.
d831e10
@Rup-Narayan-Rajbanshi @thenav56
Add validation limiting two hierarical issue.
70174f6
@Rup-Narayan-Rajbanshi @thenav56
Add validation for question in admin side.
7fa956b 
- Add filter publication_date in assessment_registry list.
@Rup-Narayan-Rajbanshi @thenav56
Clean up code.
64f0a4b
@Rup-Narayan-Rajbanshi @thenav56
Aggregated all stakeholder into single field in assessment_registry.
030bc8e 
- Add dataloader in assessment_registry
@Rup-Narayan-Rajbanshi @thenav56
Add dataloader for SummarySubPillarIssue
3418fc7
@shreeyash07 shreeyash07 mentioned this pull request Aug 17, 2023
Merged
11 tasks
@thenav56 thenav56 force-pushed the feature/summary-score-cna branch 2 times, most recently from 37a447c to 11b29ea Compare August 17, 2023 05:05
@thenav56
Review fix
11b29ea 
- Flake8 issues
- Use `only_fields` instead of deprecated `fields`
- Update enum value TODO
- Use ID! for clientID type
@thenav56 thenav56 merged commit 05c6461 into project/assessment-registry Aug 17, 2023
3 checks passed
@thenav56 thenav56 deleted the feature/summary-score-cna branch August 17, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thenav56 thenav56 thenav56 approved these changes

@bewakes bewakes Awaiting requested review from bewakes

@bimal125 bimal125 Awaiting requested review from bimal125

Assignees

@thenav56 thenav56

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rup-Narayan-Rajbanshi @thenav56