Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/publish geoarea mutation #1472

Closed

Conversation

sudan45
Copy link
Contributor

@sudan45 sudan45 commented Apr 8, 2024

Addresses

Depends

Mention related users here if any.

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@thenav56
Copy link
Member

thenav56 commented Apr 8, 2024

@sudan45 This includes a lot of changes. Can you check why?

@sudan45 sudan45 force-pushed the features/publish-geoarea-mutation branch from 1e35311 to e4fc89e Compare April 8, 2024 10:35
@sudan45 sudan45 force-pushed the features/add-region-mutation branch from 5e1b56a to df9b4fa Compare April 8, 2024 10:38
@sudan45 sudan45 force-pushed the features/publish-geoarea-mutation branch from e4fc89e to b652dd0 Compare April 8, 2024 10:53
@sudan45 sudan45 closed this Apr 8, 2024
@sudan45 sudan45 reopened this Apr 8, 2024
@sudan45 sudan45 force-pushed the features/add-region-mutation branch 3 times, most recently from 94d0af6 to 528ba78 Compare April 30, 2024 09:19
@sudan45 sudan45 assigned AdityaKhatri and subinasr and unassigned sudan45 May 2, 2024
apps/geo/serializers.py Outdated Show resolved Hide resolved
apps/geo/serializers.py Outdated Show resolved Hide resolved
@sudan45 sudan45 force-pushed the features/add-region-mutation branch 3 times, most recently from 8131449 to 1bdeb38 Compare June 4, 2024 06:23
@sudan45 sudan45 force-pushed the features/add-region-mutation branch from 1bdeb38 to 06460bd Compare June 4, 2024 06:28
@sudan45 sudan45 force-pushed the features/publish-geoarea-mutation branch from b652dd0 to 6269aea Compare June 5, 2024 04:53
@sudan45 sudan45 force-pushed the features/publish-geoarea-mutation branch from 6269aea to 97d5418 Compare June 5, 2024 06:09
@sudan45 sudan45 force-pushed the features/add-region-mutation branch 3 times, most recently from 07a42cc to a4bcf37 Compare June 5, 2024 09:52
@thenav56
Copy link
Member

thenav56 commented Jun 7, 2024

@sudan45 Let's rebase this

@sudan45 sudan45 force-pushed the features/add-region-mutation branch from a4bcf37 to 0945b35 Compare June 7, 2024 08:22
@sudan45 sudan45 force-pushed the features/add-region-mutation branch from 0945b35 to db68b1c Compare June 7, 2024 08:23
@sudan45 sudan45 force-pushed the features/publish-geoarea-mutation branch from 97d5418 to 89181cc Compare June 7, 2024 08:27
@sudan45 sudan45 marked this pull request as ready for review June 7, 2024 08:27
Copy link
Member

@susilnem susilnem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sudan45
Copy link
Contributor Author

sudan45 commented Jul 3, 2024

This branch has been merged with features/add-region-mutation

@sudan45 sudan45 force-pushed the features/add-region-mutation branch from 29d2319 to 37156fd Compare July 17, 2024 08:42
@sudan45 sudan45 force-pushed the features/add-region-mutation branch 3 times, most recently from f8de780 to 6d317f3 Compare July 30, 2024 09:03
@sudan45
Copy link
Contributor Author

sudan45 commented Jul 31, 2024

Code merge this branch

@sudan45 sudan45 closed this Jul 31, 2024
@thenav56 thenav56 deleted the features/publish-geoarea-mutation branch July 31, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants