Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OCR integration feature for NLP-based image and attachment #1505

Merged
merged 17 commits into from
Jul 9, 2024
Merged

Add OCR integration feature for NLP-based image and attachment #1505

merged 17 commits into from
Jul 9, 2024

Conversation

sudan45
Copy link
Contributor

@sudan45 sudan45 commented Jun 6, 2024 •
edited
Loading

Addresses

Changes

  • LeadPreviewImages change into LeadPreviewAttachment

Mention related users here if any.

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

thenav56
thenav56 requested changes Jun 7, 2024
View reviewed changes
Copy link
Member

@thenav56 thenav56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

apps/lead/models.py Outdated Show resolved Hide resolved
apps/lead/tests/test_apis.py Outdated Show resolved Hide resolved
apps/lead/migrations/0050_auto_20240606_0608.py Outdated Show resolved Hide resolved
apps/lead/schema.py Outdated Show resolved Hide resolved
apps/lead/schema.py Outdated Show resolved Hide resolved
apps/lead/schema.py Outdated Show resolved Hide resolved
apps/lead/schema.py Outdated Show resolved Hide resolved
apps/deepl_integration/serializers.py Outdated Show resolved Hide resolved
apps/deepl_integration/serializers.py Show resolved Hide resolved
apps/deepl_integration/handlers.py Outdated Show resolved Hide resolved
@sudan45 sudan45 marked this pull request as draft June 7, 2024 06:22
thenav56
thenav56 requested changes Jun 10, 2024
View reviewed changes
apps/entry/serializers.py Outdated Show resolved Hide resolved
apps/entry/models.py Show resolved Hide resolved
apps/entry/models.py Outdated Show resolved Hide resolved
apps/entry/schema.py Outdated Show resolved Hide resolved
apps/entry/schema.py Outdated Show resolved Hide resolved
apps/entry/schema.py Show resolved Hide resolved
apps/deepl_integration/handlers.py Outdated Show resolved Hide resolved
apps/deepl_integration/handlers.py Outdated Show resolved Hide resolved
apps/deepl_integration/handlers.py Outdated Show resolved Hide resolved
apps/deepl_integration/handlers.py Outdated Show resolved Hide resolved
@sudan45 sudan45 force-pushed the feature/ocr-integration branch 4 times, most recently from f9e973b to aad6f77 Compare June 13, 2024 04:22
@sudan45 sudan45 changed the title Add LeadreviewAttachment Model Add OCR integration feature for NLP-based image and attachment Jun 13, 2024
thenav56
thenav56 requested changes Jun 13, 2024
View reviewed changes
apps/entry/serializers.py Outdated Show resolved Hide resolved
apps/entry/serializers.py Outdated Show resolved Hide resolved
apps/lead/filter_set.py Outdated Show resolved Hide resolved
@sudan45 sudan45 force-pushed the feature/ocr-integration branch 4 times, most recently from 8cdadc6 to adcd665 Compare June 18, 2024 06:38
subinasr
subinasr reviewed Jun 19, 2024
View reviewed changes
apps/entry/schema.py Outdated Show resolved Hide resolved
@sudan45 sudan45 force-pushed the feature/ocr-integration branch 2 times, most recently from bdc0401 to 56c2530 Compare June 19, 2024 11:42
@sudan45 sudan45 marked this pull request as ready for review June 20, 2024 04:58
susilnem
susilnem approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@susilnem susilnem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sudan45 sudan45 force-pushed the feature/ocr-integration branch 2 times, most recently from d927794 to a9daaf2 Compare June 26, 2024 06:21
@sudan45 sudan45 requested a review from thenav56 June 27, 2024 09:00
@sudan45 sudan45 force-pushed the feature/ocr-integration branch 2 times, most recently from efb2bbc to 0eb1030 Compare July 5, 2024 05:37
thenav56
thenav56 requested changes Jul 5, 2024
View reviewed changes
apps/entry/migrations/0038_auto_20240609_0904.py Outdated Show resolved Hide resolved
apps/entry/models.py Outdated Show resolved Hide resolved
apps/gallery/enums.py Outdated Show resolved Hide resolved
apps/gallery/views.py Outdated Show resolved Hide resolved
apps/gallery/views.py Outdated Show resolved Hide resolved
apps/lead/migrations/0051_auto_20240625_0509.py Outdated Show resolved Hide resolved
apps/unified_connector/migrations/0010_auto_20240625_0806.py Outdated Show resolved Hide resolved
apps/entry/schema.py Outdated Show resolved Hide resolved
apps/lead/schema.py Show resolved Hide resolved
apps/lead/schema.py Show resolved Hide resolved
thenav56
thenav56 requested changes Jul 5, 2024
View reviewed changes
apps/gallery/utils.py Outdated Show resolved Hide resolved
deep/urls.py Outdated Show resolved Hide resolved
apps/gallery/tests/test_apis.py Outdated Show resolved Hide resolved
apps/gallery/tests/test_apis.py Outdated Show resolved Hide resolved
apps/gallery/tests/test_apis.py Outdated Show resolved Hide resolved
apps/gallery/tests/test_apis.py Outdated Show resolved Hide resolved
apps/entry/models.py Outdated Show resolved Hide resolved
apps/gallery/views.py Outdated Show resolved Hide resolved
thenav56
thenav56 requested changes Jul 9, 2024
View reviewed changes
apps/gallery/tests/test_apis.py Show resolved Hide resolved
apps/gallery/utils.py Outdated Show resolved Hide resolved
apps/gallery/utils.py Outdated Show resolved Hide resolved
@sudan45 sudan45 force-pushed the feature/ocr-integration branch 2 times, most recently from b3d8293 to 5526028 Compare July 9, 2024 04:21
susilnem
susilnem approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@susilnem susilnem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM!

@subinasr subinasr merged commit 6d9f690 into develop Jul 9, 2024
8 of 9 checks passed
@subinasr subinasr deleted the feature/ocr-integration branch July 9, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susilnem susilnem susilnem approved these changes

@thenav56 thenav56 thenav56 approved these changes

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi Awaiting requested review from Rup-Narayan-Rajbanshi

@subinasr subinasr Awaiting requested review from subinasr

Assignees

@AdityaKhatri AdityaKhatri

@subinasr subinasr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sudan45 @thenav56 @subinasr @susilnem @AdityaKhatri