Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for update AssessmentRegistry Mutation #1523

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

sauravsapkota
Copy link
Contributor

@sauravsapkota sauravsapkota commented Aug 1, 2024

Addresses

Changes

  • Add test case for update AssessmentRegistry
  • ID required from not-required on UpdateAssessmentRegistry Mutation
  • Add AssessmentRegistryOrganizationFactory for AssessmentRegistryOrganization Model
  • Add validation on AssessmentRegistrySerializer to check if Lead does belong to the Project
  • Change command docker-compose to docker compose

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@sauravsapkota sauravsapkota force-pushed the feature/test-update-assessment-registry branch from 6b48cc7 to d27a687 Compare August 1, 2024 05:39
@sauravsapkota sauravsapkota changed the title Add test case for update AssessmentRegistry Add test case for update AssessmentRegistry Mutation Aug 1, 2024
@sauravsapkota sauravsapkota requested review from thenav56, sudan45, susilnem and a team August 1, 2024 05:54
@sauravsapkota sauravsapkota marked this pull request as ready for review August 1, 2024 08:13
Copy link
Contributor

@sudan45 sudan45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thenav56 dai @sauravsapkota should we use snapshot in this case

apps/assessment_registry/tests/test_mutation.py Outdated Show resolved Hide resolved
apps/assessment_registry/tests/test_mutation.py Outdated Show resolved Hide resolved
@sauravsapkota sauravsapkota force-pushed the feature/test-update-assessment-registry branch 2 times, most recently from bdcbc3a to aeca733 Compare August 5, 2024 12:12
apps/assessment_registry/tests/test_mutation.py Outdated Show resolved Hide resolved
apps/assessment_registry/tests/test_mutation.py Outdated Show resolved Hide resolved
apps/assessment_registry/tests/test_mutation.py Outdated Show resolved Hide resolved
Copy link
Member

@susilnem susilnem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a question

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@sauravsapkota sauravsapkota force-pushed the feature/test-update-assessment-registry branch from f704be8 to 5ede6da Compare August 7, 2024 10:32
@sauravsapkota sauravsapkota force-pushed the feature/test-update-assessment-registry branch from 5ede6da to a2c2bec Compare August 8, 2024 05:31
@sauravsapkota sauravsapkota force-pushed the feature/test-update-assessment-registry branch from a2c2bec to 6648f4a Compare August 8, 2024 05:46
Copy link
Member

@susilnem susilnem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

susilnem

This comment was marked as spam.

@sauravsapkota sauravsapkota force-pushed the feature/test-update-assessment-registry branch from 6648f4a to 16f4ed4 Compare August 14, 2024 10:00
@thenav56 thenav56 force-pushed the feature/test-update-assessment-registry branch from 6d104c9 to 78bc438 Compare August 21, 2024 05:06
sauravsapkota and others added 4 commits August 21, 2024 10:51
diff --git a/README.md b/README.md
index 2ff399cc5..8e09211e4 100644
--- a/README.md
+++ b/README.md
@@ -10,7 +10,7 @@ Add this to your `.git/hooks/pre-commit` to generate latest graphql schema befor
 #!/bin/sh

 echo "pre-commit: Generating graphql schema."
-if [ -z `docker ps -q --no-trunc | grep $(docker-compose ps -q web)` ]; then
+if [ -z `docker ps -q --no-trunc | grep $(docker compose ps -q web)` ]; then
     docker compose run --rm web ./manage.py graphql_schema --out schema.graphql
 else
     docker compose exec -T web ./manage.py graphql_schema --out schema.graphql
@subinasr subinasr merged commit 2e1bfeb into develop Aug 22, 2024
9 checks passed
@subinasr subinasr deleted the feature/test-update-assessment-registry branch August 22, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants