Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCR filter #1526

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

OCR filter #1526

wants to merge 2 commits into from

Conversation

sudan45
Copy link
Contributor

@sudan45 sudan45 commented Aug 30, 2024

Implement GraphQL filters for LeadPreviewAttachment by type and excluding specific IDs.

Mention related users here if any.

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@sudan45 sudan45 changed the title Add field in lead attachment filter OCR filter f Aug 30, 2024
@sudan45 sudan45 changed the title OCR filter f OCR filter Aug 30, 2024
@AdityaKhatri AdityaKhatri self-assigned this Oct 1, 2024
@@ -556,13 +556,15 @@ def filter_title(self, qs, name, value):
class LeadPreviewAttachmentGQFilterSet(UserResourceGqlFilterSet):
type = MultipleInputFilter(LeadPreviewAttachmentTypeEnum, field_name='type')
exclude_attachment_ids = IDListFilter(method='filter_exclude_lead_attachment_ids')
exclude_with_entries = django_filters.BooleanFilter(method='filter_exclude_with_entries')
Copy link
Contributor

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be we can have some better filter name like exclude_lead_with_no_entries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants