Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create setup_debian.md #35

Merged
merged 10 commits into from
Sep 23, 2024
Merged

Create setup_debian.md #35

merged 10 commits into from
Sep 23, 2024

Conversation

ll-SKY-ll
Copy link
Contributor

@ll-SKY-ll ll-SKY-ll commented Sep 20, 2024

These instructions aim to provide a install guide for debian

Signed-off-by: Sky sky@codestorm.net

docs/bot/setup_debian.md Outdated Show resolved Hide resolved
ok :)

Co-authored-by: Gnuxie <50846879+Gnuxie@users.noreply.github.com>
Copy link
Member

@FSG-Cat FSG-Cat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. we maby want to have @Gnuxie consult expert on Systemd stuff worst case.

Like this can be polished after the fact but it looks decent to me.

But i found one problem. Update instructiions are missing tag fetch. As are install instructions.

@ll-SKY-ll
Copy link
Contributor Author

LGTM. we maby want to have @Gnuxie consult expert on Systemd stuff worst case.

Like this can be polished after the fact but it looks decent to me.

But i found one problem. Update instructiions are missing tag fetch. As are install instructions.

can add instructions to install a specific tag

docs/bot/setup_debian.md Outdated Show resolved Hide resolved
@Gnuxie
Copy link
Member

Gnuxie commented Sep 20, 2024

can add instructions to install a specific tag

Yeah that'll be good

I don't think the other concerns Cat raises are blocking i'd rather have this than nothing and i can get people to look at it async.

docs/bot/setup_debian.md Outdated Show resolved Hide resolved
ll-SKY-ll and others added 2 commits September 20, 2024 19:31
Co-authored-by: Gnuxie <50846879+Gnuxie@users.noreply.github.com>
removed line to add typescript globally as its not necessary
headline should start uppercase
Copy link
Member

@FSG-Cat FSG-Cat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heres the changes i want addressed but other than that im mostly happy and i think we can merge this if the workflows are happy as that means it will deploy.

docs/bot/setup_debian.md Outdated Show resolved Hide resolved
docs/bot/setup_debian.md Show resolved Hide resolved
ll-SKY-ll and others added 2 commits September 22, 2024 10:59
:)

Co-authored-by: Catalan Lover <48515417+FSG-Cat@users.noreply.github.com>
add line to fetch tags with git
Copy link
Member

@FSG-Cat FSG-Cat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concerns have been resolved so im happy.

@Gnuxie Gnuxie merged commit 36595d9 into the-draupnir-project:main Sep 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants