Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rock #148

Merged
merged 8 commits into from
Feb 21, 2024
Merged

Rock #148

merged 8 commits into from
Feb 21, 2024

Conversation

SchwartzGandhi
Copy link
Collaborator

@SchwartzGandhi SchwartzGandhi commented Feb 20, 2024

IS SONG - DO NOT DELETE THIS LINE
Game: Rhythm Heaven
Song: Big Rock Finish H
Category: events
Composers: Tsunku♂️
Converters: Schwartz Gandhi
Tags: Spawning, Collection

Copy link

Mornin'

I've analyzed your pull request and ascertained the following information from it. This will help the verifiers handle your request faster:

Is Song Upload: Yes
Has Binary File: Yes
Has Preview: Yes
Missing Mandatory Information: None
Headers which I don't understand: None
Is new game: No
Something needs changing: No

Here's what the output will look like:

{
    "Game": "Rhythm Heaven",
    "Song": "Big Rock Finish H",
    "Category": "events",
    "Composers": "Tsunku♂️",
    "Converters": "Schwartz Gandhi",
    "Tags": [
        "spawning",
        "collection"
    ],
    "Verified": true,
    "Date": "Tue Feb 20 2024 09:11:43 GMT+0000 (Coordinated Universal Time)",
    "Audio": "https://github.com/theballaam96/candys-shop/raw/main/previews/Rhythm%20Heaven/Big%20Rock%20Finish%20H.mp3",
    "Binary": "binaries/Rhythm Heaven/Big Rock Finish H.bin",
    "Duration": 8.562491437500002
}

@Brian0255
Copy link
Collaborator

This is great, but it's honestly too loud. I think you should lower the overall volume a bit, but the guitars at the end are especially loud and causing it to hit -8 on the Loudness meter which is much, much higher than average.

Also, if you can, please use the submission form to auto-generate the pull request text. Case sensitivity matters and you have lowercase here (and in your last submission) on a few fields. I went ahead and fixed it in your last submission, but if you could fix it here that would be great! Thanks.

@SchwartzGandhi
Copy link
Collaborator Author

@Brian0255 I'm not entirely sure what you're on about, Both of these show that its fine, looked back at the discord convo a few days ago and you said things should be around -15ish, which it is. Not trying to be rude or anything, I just want to know what I should be looking for.
image
image

@SchwartzGandhi
Copy link
Collaborator Author

IS SONG - DO NOT DELETE THIS LINE
Game: Rhythm Heaven
Song: Big Rock Finish H
Category: events
Composers: Tsunku♂️
Converters: Schwartz Gandhi
Tags: Spawning, Collection

@theballaam96
Copy link
Owner

You need to edit your original description

Copy link

Mornin'

I've analyzed your pull request and ascertained the following information from it. This will help the verifiers handle your request faster:

Is Song Upload: Yes
Has Binary File: Yes
Has Preview: Yes
Missing Mandatory Information: None
Headers which I don't understand: None
Is new game: No
Something needs changing: No

Here's what the output will look like:

{
    "Game": "Rhythm Heaven",
    "Song": "Big Rock Finish H",
    "Category": "events",
    "Composers": "Tsunku♂️",
    "Converters": "Schwartz Gandhi",
    "Tags": [
        "Spawning",
        "Collection"
    ],
    "Verified": true,
    "Date": "Tue Feb 20 2024 19:59:56 GMT+0000 (Coordinated Universal Time)",
    "Audio": "https://github.com/theballaam96/candys-shop/raw/main/previews/Rhythm%20Heaven/Big%20Rock%20Finish%20H.mp3",
    "Binary": "binaries/Rhythm Heaven/Big Rock Finish H.bin",
    "Duration": 8.562491437500002
}

@wibdiwoh wibdiwoh merged commit 2fb3ed0 into theballaam96:main Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants