Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #121

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Add files via upload #121

merged 1 commit into from
Feb 17, 2024

Conversation

HothRaka
Copy link
Contributor

@HothRaka HothRaka commented Feb 15, 2024

IS SONG - DO NOT DELETE THIS LINE
Game: Phoenix Wright: Ace Attorney
Song: Objection (2001)
Composers: Masakazu Sugimori
Converters: HothRaka
Category: bgm
Update Notes: I don't know why I used a xylophone on my original submission lmao, I think the instruments sound a lot better now. I also added a funni little vocal sting at the beginning to represent the OBJECTION
Tags: Lobbies and Shops, Interiors, Happy, Calm

Copy link

Mornin'

I've analyzed your pull request and ascertained the following information from it. This will help the verifiers handle your request faster:

Is Song Upload: No
Something needs changing: No

Copy link

Mornin'

I've analyzed your pull request and ascertained the following information from it. This will help the verifiers handle your request faster:

Is Song Upload: Yes
Has Binary File: Yes
Has Preview: Yes
Missing Mandatory Information: None
Headers which I don't understand: None
Is new game: No
Something needs changing: No

Here's what the output will look like:

{
    "Game": "Phoenix Wright: Ace Attorney",
    "Song": "Objection (2001)",
    "Composers": "Masakazu Sugimori",
    "Converters": "HothRaka",
    "Category": "bgm",
    "Update Notes": "I don't know why I used a xylophone on my original submission lmao, I think the instruments sound a lot better now. I also added a funni little vocal sting at the beginning to represent the OBJECTION",
    "Tags": [
        "Lobbies and Shops",
        "Interiors",
        "Exteriors",
        "Happy",
        "Calm"
    ],
    "Verified": true,
    "Date": "Thu Feb 15 2024 02:44:07 GMT+0000 (Coordinated Universal Time)",
    "Audio": "https://github.com/theballaam96/candys-shop/raw/main/previews/Phoenix%20Wright%20Ace%20Attorney/Objection%20(2001).mp3",
    "Binary": "binaries/Phoenix Wright Ace Attorney/Objection (2001).bin",
    "Duration": 48.8125
}

@Brian0255
Copy link
Collaborator

Great update! The harp is definitely a lot better than the xylophone (at least to me). The only suggestion I would make is to remove the Exteriors tag since this song is on the shorter side. In general, 3 tags for a song is pretty uncommon and it helps out the song placing algorithm if songs are only being placed where they fit the most.

Copy link

Mornin'

I've analyzed your pull request and ascertained the following information from it. This will help the verifiers handle your request faster:

Is Song Upload: Yes
Has Binary File: Yes
Has Preview: Yes
Missing Mandatory Information: None
Headers which I don't understand: None
Is new game: No
Something needs changing: No

Here's what the output will look like:

{
    "Game": "Phoenix Wright: Ace Attorney",
    "Song": "Objection (2001)",
    "Composers": "Masakazu Sugimori",
    "Converters": "HothRaka",
    "Category": "bgm",
    "Update Notes": "I don't know why I used a xylophone on my original submission lmao, I think the instruments sound a lot better now. I also added a funni little vocal sting at the beginning to represent the OBJECTION",
    "Tags": [
        "Lobbies and Shops",
        "Interiors",
        "Happy",
        "Calm"
    ],
    "Verified": true,
    "Date": "Sat Feb 17 2024 02:06:06 GMT+0000 (Coordinated Universal Time)",
    "Audio": "https://github.com/theballaam96/candys-shop/raw/main/previews/Phoenix%20Wright%20Ace%20Attorney/Objection%20(2001).mp3",
    "Binary": "binaries/Phoenix Wright Ace Attorney/Objection (2001).bin",
    "Duration": 48.8125
}

@Brian0255 Brian0255 merged commit f683370 into theballaam96:main Feb 17, 2024
4 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants