Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #124

Closed
wants to merge 0 commits into from
Closed

Conversation

SirEnobMort
Copy link
Collaborator

IS SONG - DO NOT DELETE THIS LINE
Game: Mario Party
Song: Mushroom Bank Theme
Composers: Yasunori Mitsuda
Converters: SirEnobMort
Category: bgm
Tags: Lobbies and Shops, Happy

Copy link

Mornin'

I've analyzed your pull request and ascertained the following information from it. This will help the verifiers handle your request faster:

Is Song Upload: Yes
Has Binary File: Yes
Has Preview: Yes
Missing Mandatory Information: None
Headers which I don't understand: None
Is new game: No
Something needs changing: No

Here's what the output will look like:

{
    "Game": "Mario Party",
    "Song": "Mushroom Bank Theme",
    "Composers": "Yasunori Mitsuda",
    "Converters": "SirEnobMort",
    "Category": "bgm",
    "Tags": [
        "Lobbies and Shops",
        "Happy"
    ],
    "Verified": true,
    "Date": "Fri Feb 16 2024 04:17:37 GMT+0000 (Coordinated Universal Time)",
    "Audio": "https://github.com/theballaam96/candys-shop/raw/main/previews/Mario%20Party/Mushroom%20Bank%20Theme.mp3",
    "Binary": "binaries/Mario Party/Mushroom Bank Theme.bin",
    "Duration": 15.41665125
}

@theballaam96
Copy link
Owner

I've seen you've added a second set of songs to your repository. To make a second submission, you need to create a new branch on your repository and have your files on that branch and that branch alone. PRs for new songs won't work with multiple songs.

I would advise the following steps:

  1. Delete the mushroom shop files from your repo. To do this, you can click the file on the file list in GitHub, then click the 3 dots on the top right, and click "Delete File". You'll want to do this for all 3 mushroom shop files. This will make this PR valid again
  2. Go back to your repo, then at the top-left, you should see a button which says "main". Click that, then in the search box, type in the name of your song or some other unique name. Once you have done that, it'll say below "Create Branch {whatever name you chose} from main". Once you have done that, you will have created a new branch. You can then upload your mushroom shops songs to that branch.
  3. To PR that new branch, do the same steps as you would normally, but when you create the PR, it'll allow you to select the branch you want to PR from. Normally it's "main", but since you created a secondary branch, you can select that instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants