Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #143

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

HothRaka
Copy link
Contributor

@HothRaka HothRaka commented Feb 18, 2024

IS SONG - DO NOT DELETE THIS LINE
Game: Castlevania: Dawn of Sorrow
Song: Demon Castle Pinnacle
Composers: Masahiko Kimura & Michiru Yamane
Converters: HothRaka
Category: bgm
Tags: Fights, Exteriors, Gloomy

Copy link

Mornin'

I've analyzed your pull request and ascertained the following information from it. This will help the verifiers handle your request faster:

Is Song Upload: Yes
Has Binary File: Yes
Has Preview: Yes
Missing Mandatory Information: None
Headers which I don't understand: None
Is new game: No
Something needs changing: No

Here's what the output will look like:

{
    "Game": "Castlevania: Dawn of Sorrow",
    "Song": "Demon Castle Pinnacle",
    "Composers": "Masahiko Kimura & Michiru Yamane",
    "Converters": "HothRaka",
    "Category": "bgm",
    "Tags": [
        "Fights",
        "Interiors",
        "Exteriors",
        "Gloomy"
    ],
    "Verified": true,
    "Date": "Sun Feb 18 2024 20:46:57 GMT+0000 (Coordinated Universal Time)",
    "Audio": "https://github.com/theballaam96/candys-shop/raw/main/previews/Castlevania%20Dawn%20of%20Sorrow/Demon%20Castle%20Pinnacle.mp3",
    "Binary": "binaries/Castlevania Dawn of Sorrow/Demon Castle Pinnacle.bin",
    "Duration": 121.78691525
}

Copy link

Mornin'

I've analyzed your pull request and ascertained the following information from it. This will help the verifiers handle your request faster:

Is Song Upload: Yes
Has Binary File: Yes
Has Preview: Yes
Missing Mandatory Information: None
Headers which I don't understand: None
Is new game: No
Something needs changing: No

Here's what the output will look like:

{
    "Game": "Castlevania: Dawn of Sorrow",
    "Song": "Demon Castle Pinnacle",
    "Composers": "Masahiko Kimura & Michiru Yamane",
    "Converters": "HothRaka",
    "Category": "bgm",
    "Tags": [
        "Fights",
        "Exteriors",
        "Gloomy"
    ],
    "Verified": true,
    "Date": "Sun Feb 18 2024 20:54:29 GMT+0000 (Coordinated Universal Time)",
    "Audio": "https://github.com/theballaam96/candys-shop/raw/main/previews/Castlevania%20Dawn%20of%20Sorrow/Demon%20Castle%20Pinnacle.mp3",
    "Binary": "binaries/Castlevania Dawn of Sorrow/Demon Castle Pinnacle.bin",
    "Duration": 121.78691525
}

@theballaam96
Copy link
Owner

Removed the "Interiors" tag on this one. Generally using 3 location tags should be a pretty rare occasion.

Additionally, the "Interiors" and "Exteriors" tag being used on the same song should be incredibly rare that they're practically mutually exclusive.

@theballaam96 theballaam96 merged commit 52139e1 into theballaam96:main Feb 19, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants