Landstalker: The Treasures of King Nole - To Great Adventures

[SnolidIce]

IS SONG - DO NOT DELETE THIS LINE
Game: Landstalker: The Treasures of King Nole
Song: To Great Adventures
Composers: Motoaki Takenouchi
Converters: Snolid Ice
Category: bgm
Tags: Exteriors, Happy

[github-actions]

Mornin'

I've analyzed your pull request and ascertained the following information from it. This will help the verifiers handle your request faster:

Is Song Upload: Yes
Has Binary File: Yes
Has Preview: Yes
Missing Mandatory Information: None
Headers which I don't understand: None
Is new game: No
Something needs changing: No

Here's what the output will look like:

{
    "Game": "Landstalker: The Treasures of King Nole",
    "Song": "To Great Adventures",
    "Composers": "Motoaki Takenouchi",
    "Converters": "Snolid Ice",
    "Category": "bgm",
    "Audio": "https://github.com/theballaam96/candys-shop/raw/main/previews/Landstalker%20The%20Treasures%20of%20King%20Nole/To%20Great%20Adventures.mp3",
    "Tags": [
        "Exteriors",
        "Happy"
    ],
    "Verified": true,
    "Date": "Thu Feb 22 2024 23:52:11 GMT+0000 (Coordinated Universal Time)",
    "Binary": "binaries/Landstalker The Treasures of King Nole/To Great Adventures.bin",
    "Duration": 224.12665852083333
}

[SnolidIce]

oh i see thank you, i just took it from the submission form cause i havent submitted like this before , how do i get the duration and time or is there no easy way to get that

[theballaam96]

oh i see thank you, i just took it from the submission form cause i havent submitted like this before , how do i get the duration and time or is there no easy way to get that

Looks all good in terms of the data provided. The message from the github-actions bot is just a canary we use to check to see whether everything is good with the submission text without us having to deep dive.

In terms of the duration & time, this is automatically grabbed from the MIDI file, hence why this is mandatory. The time is also just grabbed from a javascript function.

In general, unless the message from the bot includes:

Something needs changing: Yes

you don't need to worry about anything unless we say otherwise

EDIT: Removed the "Audio" field from your submission. This is only necessary if you're not uploading a .mp3 file to GitHub. Additionally, if you decide to not upload a .mp3 to GitHub, please use that for ONLY youtube links. Our parser cannot understand Google Drive links because it gets CORS blocked

[github-actions]

Mornin'

I've analyzed your pull request and ascertained the following information from it. This will help the verifiers handle your request faster:

Is Song Upload: Yes
Has Binary File: Yes
Has Preview: Yes
Missing Mandatory Information: None
Headers which I don't understand: None
Is new game: No
Something needs changing: No

Here's what the output will look like:

{
    "Game": "Landstalker: The Treasures of King Nole",
    "Song": "To Great Adventures",
    "Composers": "Motoaki Takenouchi",
    "Converters": "Snolid Ice",
    "Category": "bgm",
    "Tags": [
        "Exteriors",
        "Happy"
    ],
    "Verified": true,
    "Date": "Fri Feb 23 2024 05:33:57 GMT+0000 (Coordinated Universal Time)",
    "Audio": "https://github.com/theballaam96/candys-shop/raw/main/previews/Landstalker%20The%20Treasures%20of%20King%20Nole/To%20Great%20Adventures.mp3",
    "Binary": "binaries/Landstalker The Treasures of King Nole/To Great Adventures.bin",
    "Duration": 224.12665852083333
}

[wibdiwoh]

mornin

i apologize for the delay in getting to this, we had a few things to sort out!

we at the music-verifying team have spotted a few things that we'd like you to improve:

1 - the bass is panned way too hard to the side, we'd like you to ease a bit on the panning! anywhere between 10% and 30% should work just fine.

2 - the way your version of the song loops isn't ideal... we understand that the original does not have a loop, but since it will loop during dk64 gameplay it is important to find a solution for that! we currently don't have a rule regarding what to do with situations like this, but in your case i suggest removing part of the ending of the song. you can loop to the beginning from the point at 3 mins 22 secs in your mp3 preview.

3 - there's one particular spot in your song that stands out as being too loud, it happens at 0 mins 53 secs in your mp3 preview and i've circled it in the graph below. it is a bass crescendo, and we need you to reduce it's volume by quite a bit.

everything else is great! once these issues are solved, your conversion will be approved

[SnolidIce]

@wibdiwoh alright i changed the loop, lowered the bass volume and made the pan centered.

idk how i feel about making the volume on the bass lower, i can barley hear it in most parts of the song

[wibdiwoh]

oh but you didn't need to lower the bass in the entire song, just in the part i showed in the graph! i took a quick look at the new preview, and that part still sticks out a bit:

it's only 6 notes in total, you could just lower the velocity of those notes instead of lowering the volume of the entire channel!

you can bring the volume for the bass back up if you want, but that specific part needs to be lower so it doesn't spike so much.

[SnolidIce]

oh ok i got confused with which part it was, let me fix it really quickly sorry

[SnolidIce]

alright i did that, if there is anything else i need to do lmk, if its all good to go if u could close the pr after getting the files/info that would be awesome so i dont have to make a new fork thank you, have a good day :)