Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mario Party 2 - Woody #201

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Mario Party 2 - Woody #201

merged 1 commit into from
Mar 10, 2024

Conversation

SirEnobMort
Copy link
Collaborator

@SirEnobMort SirEnobMort commented Mar 9, 2024

IS SONG - DO NOT DELETE THIS LINE
Game: Mario Party 2
Song: Woody
Composers: Hironao Yamamoto, Shohei Bando, Kazuhiko Sawaguchi
Converters: SirEnobMort
Category: bgm
Tags: Lobbies and Shops, Gloomy, Calm

Copy link

github-actions bot commented Mar 9, 2024

Mornin'

I've analyzed your pull request and ascertained the following information from it. This will help the verifiers handle your request faster:

Is Song Upload: Yes
Has Binary File: Yes
Has Preview: Yes
Missing Mandatory Information: None
Headers which I don't understand: None
Is new game: No
Something needs changing: No

Here's what the output will look like:

{
    "Game": "Mario Party 2",
    "Song": "Woody",
    "Composers": "Hironao Yamamoto, Shohei Bando, Kazuhiko Sawaguchi",
    "Converters": "SirEnobMort",
    "Category": "bgm",
    "Tags": [
        "Lobbies and Shops",
        "Interiors",
        "Gloomy",
        "Calm"
    ],
    "Verified": true,
    "Date": "Sat Mar 09 2024 07:32:29 GMT+0000 (Coordinated Universal Time)",
    "Audio": "https://github.com/theballaam96/candys-shop/raw/main/previews/Mario%20Party%202/Woody.mp3",
    "Binary": "binaries/Mario Party 2/Woody.bin",
    "Duration": 13.108557874999997
}

@Brian0255
Copy link
Collaborator

Sounds great! However, I think this one is short enough to where it should just be Lobbies and Shops.

@SirEnobMort
Copy link
Collaborator Author

SirEnobMort commented Mar 10, 2024

Yeah, I agree. I only put Interiors because it would be a funny song for the Pirate Ship "Sickbay", lol. But I understand it's really short so would get annoying if on loop if it was randomly selected for a larger Interior. Hope to hear it on Wrinkly Kong, haha!

Copy link

Mornin'

I've analyzed your pull request and ascertained the following information from it. This will help the verifiers handle your request faster:

Is Song Upload: Yes
Has Binary File: Yes
Has Preview: Yes
Missing Mandatory Information: None
Headers which I don't understand: None
Is new game: No
Something needs changing: No

Here's what the output will look like:

{
    "Game": "Mario Party 2",
    "Song": "Woody",
    "Composers": "Hironao Yamamoto, Shohei Bando, Kazuhiko Sawaguchi",
    "Converters": "SirEnobMort",
    "Category": "bgm",
    "Tags": [
        "Lobbies and Shops",
        "Gloomy",
        "Calm"
    ],
    "Verified": true,
    "Date": "Sun Mar 10 2024 04:48:03 GMT+0000 (Coordinated Universal Time)",
    "Audio": "https://github.com/theballaam96/candys-shop/raw/main/previews/Mario%20Party%202/Woody.mp3",
    "Binary": "binaries/Mario Party 2/Woody.bin",
    "Duration": 13.108557874999997
}

@Brian0255 Brian0255 merged commit f646749 into theballaam96:main Mar 10, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants