Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #213

Merged

Conversation

ZionJaymes
Copy link
Contributor

@ZionJaymes ZionJaymes commented Mar 10, 2024

IS SONG - DO NOT DELETE THIS LINE
Game: Touhou Eiyashou ~ Imperishable Night
Song: Lunatic Eyes ~ Invisible Full Moon
Composers: ZUN
Converters: Zion Jaymes
Category: bgm
Additional Notes: Stoopid Wabbit. Could be a fun choice for any of the songs where you encounter Rabbit.
Tags: Fights, Minigames, Happy

Copy link

Mornin'

I've analyzed your pull request and ascertained the following information from it. This will help the verifiers handle your request faster:

Is Song Upload: No
Something needs changing: No

Copy link

Mornin'

I've analyzed your pull request and ascertained the following information from it. This will help the verifiers handle your request faster:

Is Song Upload: Yes
Has Binary File: Yes
Has Preview: No
Missing Mandatory Information: None
Headers which I don't understand: None
Is new game: No
Something needs changing: Yes

Here's what the output will look like:

{
    "Game": "Touhou Eiyashou ~ Imperishable Night",
    "Song": "Lunatic Eyes ~ Invisible Full Moon",
    "Composers": "ZUN",
    "Converters": "Zion Jaymes",
    "Category": "bgm",
    "Additional Notes": "Stoopid Wabbit. Could be a fun choice for any of the songs where you encounter Rabbit.",
    "Tags": [
        "Fights",
        "Minigames",
        "Happy"
    ],
    "Verified": true,
    "Date": "Sun Mar 10 2024 06:21:09 GMT+0000 (Coordinated Universal Time)",
    "Binary": "binaries/Touhou Eiyashou ~ Imperishable Night/Lunatic Eyes ~ Invisible Full Moon.bin",
    "Duration": 115.5
}

@theballaam96
Copy link
Owner

You've used a .m4a file for your preview. We only accept .mp3 files, which is why the bot has flagged up that something needs changing with your PR. Please delete the .m4a file from your PR and replace it with a .mp3 instead

Copy link

Mornin'

I've analyzed your pull request and ascertained the following information from it. This will help the verifiers handle your request faster:

Is Song Upload: Yes
Has Binary File: Yes
Has Preview: Yes
Missing Mandatory Information: None
Headers which I don't understand: None
Is new game: No
Something needs changing: No

Here's what the output will look like:

{
    "Game": "Touhou Eiyashou ~ Imperishable Night",
    "Song": "Lunatic Eyes ~ Invisible Full Moon",
    "Composers": "ZUN",
    "Converters": "Zion Jaymes",
    "Category": "bgm",
    "Additional Notes": "Stoopid Wabbit. Could be a fun choice for any of the songs where you encounter Rabbit.",
    "Tags": [
        "Fights",
        "Minigames",
        "Happy"
    ],
    "Verified": true,
    "Date": "Sun Mar 10 2024 06:30:07 GMT+0000 (Coordinated Universal Time)",
    "Audio": "https://github.com/theballaam96/candys-shop/raw/main/previews/Touhou%20Eiyashou%20~%20Imperishable%20Night/Lunatic%20Eyes%20~%20Invisible%20Full%20Moon.mp3",
    "Binary": "binaries/Touhou Eiyashou ~ Imperishable Night/Lunatic Eyes ~ Invisible Full Moon.bin",
    "Duration": 115.5
}

@theballaam96
Copy link
Owner

Checks have passed now, thanks for fixing that. We can now go ahead with doing our checks :)

@theballaam96
Copy link
Owner

The MIDI is pretty loud overall and needs rebalancing to be quieter. If you run the MIDI through the play song feature on the converter, it'll show a graph which shows (roughly) how loud it is. Generally it's a good idea not to go above the yellow line, and especially not above the red line.

I'd suggest using the MIDI rebalancer on the converter website and lowering it a fair bit so that these thresholds aren't hit:
image

@ZionJaymes
Copy link
Contributor Author

yea, I was afraid that might be a slight issue. I can re-balance it no problem.

@ZionJaymes
Copy link
Contributor Author

Replaced the .mid with a quieter version

@theballaam96
Copy link
Owner

Binary has to be updated too

@ZionJaymes
Copy link
Contributor Author

Thanks for your patience I am TRASH at this git stuff LOL. Literally never used it before this

@adeleine64DS
Copy link
Collaborator

That one section is still feeling a bit too loud/dense. To me it feels like a panning issue, but perhaps reducing the volume in that section further could also help. Give your tracks room to breathe, if that makes sense.

Okay, I did a buch of rebalancing and testing, and even found a mistake with the MIDI. Here's a new .mid and .bin and a new demo.
@adeleine64DS adeleine64DS merged commit c935c63 into theballaam96:main Mar 11, 2024
github-actions bot pushed a commit that referenced this pull request Mar 11, 2024
@ZionJaymes ZionJaymes deleted the Lunatic-Eyes-Invisible-Full-Moon branch May 18, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants