Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #224

Closed

Conversation

EpochPhaile
Copy link

IS SONG - DO NOT DELETE THIS LINE
Game: Final Fantasy XIV
Song: What Angel Wakes Me
Composers: Masayoshi Soken
Converters: Epoch Phaile
Category: bgm
Audio: https://youtu.be/rVcx4OqTQuE
Tags: Fights, Exteriors, Happy

Copy link

Mornin'

I've analyzed your pull request and ascertained the following information from it. This will help the verifiers handle your request faster:

Is Song Upload: Yes
Has Binary File: Yes
Has Preview: Yes
Missing Mandatory Information: None
Headers which I don't understand: None
Is new game: No
Something needs changing: No

Here's what the output will look like:

{
    "Game": "Final Fantasy XIV",
    "Song": "What Angel Wakes Me",
    "Composers": "Masayoshi Soken",
    "Converters": "Epoch Phaile",
    "Category": "bgm",
    "Audio": "https://youtu.be/rVcx4OqTQuE",
    "Tags": [
        "Fights",
        "Exteriors",
        "Happy"
    ],
    "Verified": true,
    "Date": "Sat Mar 16 2024 23:35:47 GMT+0000 (Coordinated Universal Time)",
    "Binary": "binaries/Final Fantasy XIV/What Angel Wakes Me.bin",
    "Duration": 257.61307393164066
}

@AmedMusl
Copy link
Collaborator

Mornin,
We understand this is your first conversion for DK64. The song is missing percussion which is essential to the song. We'd have to deny the song submission, and if you have any additional questions or like more info, please ask in #music-discussion channel on the DK64 Randomizer Discord

@theballaam96 theballaam96 added the needs work PR needs work before approval label Mar 27, 2024
@Brian0255 Brian0255 closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs work PR needs work before approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants