Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #95

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Add files via upload #95

merged 2 commits into from
Feb 14, 2024

Conversation

HavenKnight93
Copy link
Contributor

@HavenKnight93 HavenKnight93 commented Feb 13, 2024

IS SONG - DO NOT DELETE THIS LINE
Game: Yu-Gi-Oh! Forbidden Memories
Song: Heishin
Composers: Naoko Ishii, Hiroshi Tanabe, Waichiro Ozaki
Converters: HavenKnight93
Category: bgm
Tags: Fights, Gloomy

Copy link

Mornin'

I've analyzed your pull request and ascertained the following information from it. This will help the verifiers handle your request faster:

Is Song Upload: Yes
Has Binary File: Yes
Has Preview: Yes
Missing Mandatory Information: None
Headers which I don't understand: None
Is new game: No
Something needs changing: No

Here's what the output will look like:

{
    "Game": "Yu-Gi-Oh! Forbidden Memories",
    "Song": "Heishin",
    "Composers": "Naoko Ishii, Hiroshi Tanabe, Waichiro Ozaki",
    "Converters": "HavenKnight93",
    "Category": "bgm",
    "Audio": "https://drive.google.com/file/d/11rkYxGJlTvIALDH2EVhHqKyGZaoruBOw/view?usp=sharing",
    "Tags": [
        "Fights",
        "Gloomy"
    ],
    "Verified": true,
    "Date": "Wed Feb 14 2024 03:56:01 GMT+0000 (Coordinated Universal Time)",
    "Binary": "binaries/Yu-Gi-Oh Forbidden Memories/Heishin.bin"
}

@theballaam96
Copy link
Owner

This is mostly good to go, but I'd like to request that you upload your mp3 to here instead of using a google drive link if you could.

Once you do that, we should be good to go with this one

Copy link

Mornin'

I've analyzed your pull request and ascertained the following information from it. This will help the verifiers handle your request faster:

Is Song Upload: Yes
Has Binary File: Yes
Has Preview: Yes
Missing Mandatory Information: None
Headers which I don't understand: None
Is new game: No
Something needs changing: No

Here's what the output will look like:

{
    "Game": "Yu-Gi-Oh! Forbidden Memories",
    "Song": "Heishin",
    "Composers": "Naoko Ishii, Hiroshi Tanabe, Waichiro Ozaki",
    "Converters": "HavenKnight93",
    "Category": "bgm",
    "Tags": [
        "Fights",
        "Gloomy"
    ],
    "Verified": true,
    "Date": "Wed Feb 14 2024 16:01:27 GMT+0000 (Coordinated Universal Time)",
    "Audio": "https://github.com/theballaam96/candys-shop/raw/main/previews/Yu-Gi-Oh%20Forbidden%20Memories/Heishin.mp3",
    "Binary": "binaries/Yu-Gi-Oh Forbidden Memories/Heishin.bin",
    "Duration": 55.037358187500004
}

@theballaam96 theballaam96 merged commit 52d969e into theballaam96:main Feb 14, 2024
1 check passed
@theballaam96
Copy link
Owner

GHA hated me, had to revert. Will look into issue and will @ you on discord when I need to re-submit. Apologies for the issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants