resolve the Swift conforms to nullability conformance issue

thebrowsercompany · Feb 12, 2024 · 1f5c266 · 1f5c266
1 parent c6123c0
commit 1f5c266
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/Sources/FirebaseCore/FutureProtocol.swift b/Sources/FirebaseCore/FutureProtocol.swift
@@ -10,7 +10,7 @@ public protocol FutureProtocol {
   func Foo()
 
   //func CallOnCompletion(_ completion: @escaping (UnsafeMutableRawPointer) -> Void, _ userData: UnsafeMutableRawPointer)
-  func CallOnCompletion(_ c: UnsafeMutableRawPointer)
+  func CallOnCompletion(_ c: swift_firebase.swift_cxx_shims.firebase.CompletionType, _ userData: UnsafeMutableRawPointer?)
 }
 
 @_spi(Internal)
@@ -28,12 +28,12 @@ public extension FutureProtocol {
   func setCompletion(_ completion: @escaping () -> Void) {
     Foo()
 
-    /*
+
     withUnsafePointer(to: completion) { completion in
       CallOnCompletion({ pvCompletion in
         // XXX
       }, UnsafeMutableRawPointer(mutating: completion))
     }
-    */
+
   }
 }
diff --git a/Sources/firebase/include/FirebaseCore.hh b/Sources/firebase/include/FirebaseCore.hh
@@ -51,7 +51,7 @@ template <class R> class ConformingFuture: public ::firebase::Future<R> {
 
   void Foo() const {}
 
-  void CallOnCompletion(void* completion) const {
+  void CallOnCompletion(_Nonnull CompletionType, _Nullable void *userData) const {
     // 
   }
 } __attribute__((swift_attr("conforms_to:FirebaseCore.FutureProtocol")));