Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firebase: use bridging header and remove unnecessary header #26

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

compnerd
Copy link
Collaborator

The stdio.h is a C header, which should not be required. Prefer using the bridging header as that is available on newer toolchain releases.

The `stdio.h` is a C header, which should not be required. Prefer using
the bridging header as that is available on newer toolchain releases.
Sources/firebase/include/FirebaseCore.hh Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
@compnerd compnerd merged commit bb7ec5c into main Feb 15, 2024
1 check passed
Copy link

@brianmichel brianmichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, LGTM, this path seems uhhhhhhh kinda wild, but I'm not sure how else we'd fix this in SPM land

@compnerd compnerd deleted the compnerd/bridging branch February 15, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants