Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firebase: use bridging header and remove unnecessary header #26

Merged
merged 1 commit into from
Feb 15, 2024
Merged

firebase: use bridging header and remove unnecessary header #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
include:
- branch: development
tag: DEVELOPMENT-SNAPSHOT-2024-02-08-a
options: -Xswiftc "-I${env:SDKROOT}\usr\lib\swift_static\windows"
options: -Xswiftc "-I${env:SDKROOT}\usr\lib\swift_static\windows" -Xswiftc "-I${env:SDKROOT}\..\..\..\..\..\..\Toolchains\0.0.0+Asserts\usr\include"
compnerd marked this conversation as resolved.
Show resolved Hide resolved

name: Swift ${{ matrix.tag }}

Expand Down
4 changes: 2 additions & 2 deletions Sources/firebase/include/FirebaseCore.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

#include <firebase/util.h>

#include <stdio.h>
compnerd marked this conversation as resolved.
Show resolved Hide resolved
#include <swift/bridging>

namespace swift_firebase::swift_cxx_shims::firebase {

Expand All @@ -14,7 +14,7 @@ typedef void (*FutureCompletionType)(void*);
// Swift. We can ignore the `FutureBase` param as the Swift caller can just
// retain the Future as part of its closure.
template <class R>
class __attribute__((swift_attr("conforms_to:FirebaseCore.FutureProtocol")))
class SWIFT_CONFORMS_TO_PROTOCOL(FirebaseCore.FutureProtocol)
Future : public ::firebase::Future<R> {
public:
typedef R ResultType;
Expand Down
Loading