Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API correctness fixes for Transaction support #30

Merged
merged 4 commits into from
Feb 16, 2024
Merged

Conversation

darinf
Copy link

@darinf darinf commented Feb 16, 2024

Changes:

  • Fix signature of runTransaction's updateBlock parameter
  • Add definition of NSErrorPointer since swift-corelibs-foundation does not provide it
  • Make Transaction methods that return the Transaction to support chaining declare the result discardable so as to not generate warnings when the return value is ignored
  • Switch to a fatalError (even in release builds) if trying to use a Transaction outside of an updateBlock
  • Switch to non-mutating methods / const C++ methods so that a Transaction instance passed as a parameter to a function (updateBlock) can be used

@darinf darinf changed the title Fix signature of runTransaction updateBlock Fix issues with Transaction support Feb 16, 2024
@darinf darinf marked this pull request as ready for review February 16, 2024 06:34
@darinf darinf changed the title Fix issues with Transaction support API correctness fixes for Transaction support Feb 16, 2024
Copy link

@brianmichel brianmichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Base automatically changed from darin/document-change-fixes to main February 16, 2024 16:48
@darinf darinf merged commit d40d17b into main Feb 16, 2024
1 check passed
@darinf darinf deleted the darin/update-block-fixes branch February 16, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants