API correctness fixes for Transaction support #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
runTransaction
'supdateBlock
parameterNSErrorPointer
since swift-corelibs-foundation does not provide itTransaction
methods that return theTransaction
to support chaining declare the result discardable so as to not generate warnings when the return value is ignoredfatalError
(even in release builds) if trying to use aTransaction
outside of anupdateBlock
Transaction
instance passed as a parameter to a function (updateBlock
) can be used