Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Firestore.terminate #51

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Expose Firestore.terminate #51

merged 1 commit into from
Mar 18, 2024

Conversation

darinf
Copy link

@darinf darinf commented Mar 16, 2024 •
edited
Loading

Also fixes signature of clearPersistence to allow for a nil completion callback to match the Obj C API.

@darinf
Expose Firestore.terminate
744450d 
Also fixes signature of `clearPermanence` to allow for a nil completion
callback to match the Obj C API.
@darinf darinf marked this pull request as ready for review March 16, 2024 01:26
sherryshao
sherryshao approved these changes Mar 16, 2024
View reviewed changes
Copy link

@sherryshao sherryshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 !

@darinf darinf merged commit c14c6f4 into main Mar 18, 2024
2 checks passed
@darinf darinf deleted the darin/firestore-terminate branch March 18, 2024 15:33
@fiedukow fiedukow mentioned this pull request May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherryshao sherryshao sherryshao approved these changes

@fiedukow fiedukow Awaiting requested review from fiedukow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darinf @sherryshao