Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup the signatures of clearPersistence and terminate #53

Merged

Conversation

darinf
Copy link

@darinf darinf commented Mar 19, 2024

While the underlying C++ layer does not generate errors for these calls, the Obj C API exposes errors on these calls, so we should here as well.

While the underlying C++ layer does not generate errors for these
calls, the Obj C API exposes errors on these calls, so we should
here as well.
@darinf darinf requested a review from sherryshao March 19, 2024 04:10
Copy link

@sherryshao sherryshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, simpler than I thought

@darinf darinf merged commit 86501db into main Mar 19, 2024
2 checks passed
@darinf darinf deleted the darin/fixup-signatures-of-clearpersistence-and-terminate branch March 19, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants