Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: isolate libcurl and zlibstatic to Windows #71

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

compnerd
Copy link
Collaborator

When building for Android, we do not wish to link against this libraries, least of all because they are spelt differently (curl and z respectively). This allows us to make further progress on linking binaries for android targets.

When building for Android, we do not wish to link against this
libraries, least of all because they are spelt differently (`curl` and
`z` respectively). This allows us to make further progress on linking
binaries for android targets.
@compnerd compnerd requested a review from hyp June 18, 2024 15:24
Copy link

@hyp hyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@compnerd compnerd merged commit 3a46498 into thebrowsercompany:main Jun 18, 2024
2 checks passed
@compnerd compnerd deleted the compnerd/linkage branch June 18, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants