Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#548): about page cleanups #713

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

feat(#548): about page cleanups #713

wants to merge 3 commits into from

Conversation

barrett-ruth
Copy link
Contributor

@barrett-ruth barrett-ruth commented Oct 20, 2023

I totally didn't see #696. My mistake!!! I think this UI is preferable though.

Resolves #548.

Removes Tommy, he transferred to Columbia.

De-duplicates members in exec not in D&M.

Linkedin & GitHub icons (optionally) for all members.

Centers all members.

Before:
image

After:
image

Copy link
Contributor

@Ann924 Ann924 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some members are missing a GitHub link in this cleanup even though they had one on the original site (i.e. Check Oliver).

I understand that we might want to de-duplicate the exec members, but I feel like it would be best to be consistent in how we handle that for the engineering and design/marketing teams. For that reason, I personally lean towards keeping the duplicates.

I think the engineering team members still need to be cleaned out a bit more. If Raffi, Samyak, etc. aren't returning this semester they should be moved to "Past Contributors." Similarly, if Tommy made any contributions, he should also be in "Past Contributors". We might want to hold off on merging this PR until a couple of meetings later just to be clear on who is returning.

@barrett-ruth
Copy link
Contributor Author

barrett-ruth commented Oct 21, 2023

AJ was fine with the de-dups, we should discuss next meeting.

Moved tommy, raffi, samyak to alums. fixed oliver's github - thanks :D

@barrett-ruth
Copy link
Contributor Author

@Ann924 now that photos are resized, what do you want to do with this? I think we should just make a decision for the duplicates and stick to it. I'll update the pfps accordingly.

Currently, only the teach team is de-duplicated from exec. Otherwise every else is duplicated for their respective department.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add D&M people to the site w/ LinkedIns
2 participants