Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search indexing #840

Open
wants to merge 21 commits into
base: dev
Choose a base branch
from
Open

Search indexing #840

wants to merge 21 commits into from

Conversation

barrett-ruth
Copy link
Contributor

@barrett-ruth barrett-ruth commented Apr 17, 2024

This PR implements a hybrid reverse indexing and trigram similarity search algorithm.

Search vectors are used for courses.
Trigram similarity is used for instructors for more fine-grained matching.

Downsides:
Cold-start indexing times for generating reverse indices

TODO

  • Weighting courses versus instructors (weights should be based on testing)
  • Speed: TriGram searches are still run every time on instructors (is this superior to no trigram?)

@barrett-ruth barrett-ruth marked this pull request as ready for review May 14, 2024 19:39
artiehumphreys
artiehumphreys previously approved these changes May 26, 2024
Copy link
Member

@artiehumphreys artiehumphreys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ajnye
ajnye previously approved these changes May 28, 2024
Copy link
Member

@ajnye ajnye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's test it in prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants