Implement primitive CreateTopics and DeleteTopics methods #8

ncalibey · 2024-05-10T20:21:26Z

No description provided.

examples/create_topic.rs

.gitignore

src/client.rs

thedodd

Ping me once the rebase and such are g2g. Thanks Nick!

ncalibey · 2024-05-17T05:00:08Z

@thedodd changes made. Only question I have is around the error type for if we get an error on the oneshot receiver. Should we just wrap it in a ClientError?

thedodd · 2024-05-17T13:18:41Z

@ncalibey yea, for the oneshot channels, we have the unpack_broker_response utility function which will handle that case. It maps to a ClientError::Other(_) in that case.

thedodd · 2024-05-17T17:30:19Z

src/client.rs

+        return if let Some(leader) = &cluster.controller {
+            let uid = uuid::Uuid::new_v4();
+            leader.conn.delete_topics(uid, request, tx).await;
+            unpack_broker_response(rx).await.and_then(|(_, res)| {
+                if let ResponseKind::DeleteTopicsResponse(inner) = res {
+                    Ok(inner)
+                } else {
+                    Err(ClientError::MalformedResponse)
+                }
+            })
+        } else {
+            Err(ClientError::NoControllerFound)
+        };


Nice! I like it.

ncalibey commented May 11, 2024

View reviewed changes

examples/create_topic.rs Outdated Show resolved Hide resolved

ncalibey force-pushed the create-topics branch 2 times, most recently from 9bf6dfa to 3c6ae26 Compare May 13, 2024 16:31

ncalibey changed the title ~~Implement primitive CreateTopics method~~ Implement primitive CreateTopics and DeleteTopics methods May 13, 2024