Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update reqwest to 0.12 #72

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

ctron
Copy link
Contributor

@ctron ctron commented Mar 22, 2024

The change should be trivial. However, as crates.io seems to be down right now, I expect the CI will fail with a timeout error.

@ctron
Copy link
Contributor Author

ctron commented Mar 22, 2024

crates.io seems to be back, I guess it should be sufficient to re-trigger the job.

@theduke
Copy link
Owner

theduke commented Apr 3, 2024

There are some failing tests - might just be because of rate limiting, but could you do a quick investigation into the error message, @ctron?

@ctron
Copy link
Contributor Author

ctron commented Apr 4, 2024

Interesting. The two jobs fails for the exact same tests. But with a 500 code, which I would see on the server side.

All tests seems to fail for the path /api/v1/crates/crates_io_api/reverse_dependencies. Maybe it was an issue on the backend? I would try to re-run those tests and see what happens.

@theduke
Copy link
Owner

theduke commented Apr 4, 2024

I triggered a re-run.

@ctron
Copy link
Contributor Author

ctron commented Apr 4, 2024

I triggered a re-run.

Turning it off an on again worked :)

@theduke theduke merged commit f74c193 into theduke:main Apr 4, 2024
2 checks passed
@theduke
Copy link
Owner

theduke commented Apr 4, 2024

I'll push out a new release.

@ctron ctron deleted the feature/upgrade_reqwest_1 branch April 4, 2024 16:14
@ctron
Copy link
Contributor Author

ctron commented Apr 12, 2024

I'll push out a new release.

I didn't see the new release, am I looking in the wrong place?

@theduke
Copy link
Owner

theduke commented Apr 12, 2024

Released as 0.11.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants