Refs #36573 - Drop puppet::server_foreman_url value if redundant #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theforeman/puppetserver_foreman has started to default to copying the value from foreman_proxy::foreman_base_url when unspecified. theforeman/puppet has removed its default. This completes it by removing the value if both answers are the same. The biggest benefit is that the user only needs to care about a single answer and no longer keep them in sync. This means we can stop thinking about whether Puppet is enabled or not in all our user instructions.
evgeni
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
theforeman/puppetserver_foreman has started to default to copying the value from foreman_proxy::foreman_base_url when unspecified. theforeman/puppet has removed its default. This completes it by removing the value if both answers are the same.
The biggest benefit is that the user only needs to care about a single answer and no longer keep them in sync. This means we can stop thinking about whether Puppet is enabled or not in all our user instructions.
Depends on both theforeman/puppet-puppet#880 and theforeman/puppet-puppetserver_foreman#31 being merged.