From fd21a88ca41dd15a9d35c40908c092280f610852 Mon Sep 17 00:00:00 2001
From: Leos Stejskal <lstejska@redhat.com>
Date: Wed, 29 May 2024 16:02:20 +0200
Subject: [PATCH] Fixes #37519 - Host form - Libvirt improvements

- Provisioning a host with an image that does not exist has the correct error.
- Fixed error for the Libvirt capacity storage.
- Added error to the field when the image is not found
- Fix automatic change of storage type and size
---
 .../foreman/model/libvirt.rb                  |  2 +-
 .../form/libvirt/_base.html.erb               |  2 -
 .../javascripts/compute_resource/libvirt.js   | 44 ++++++++++++++-----
 3 files changed, 33 insertions(+), 15 deletions(-)

diff --git a/app/models/compute_resources/foreman/model/libvirt.rb b/app/models/compute_resources/foreman/model/libvirt.rb
index f4690e71f24..23d367de42b 100644
--- a/app/models/compute_resources/foreman/model/libvirt.rb
+++ b/app/models/compute_resources/foreman/model/libvirt.rb
@@ -128,7 +128,7 @@ def networks
 
     def template(id)
       template = client.volumes.get(id)
-      raise Foreman::Exception.new(N_("Unable to find template %s"), id) unless template.persisted?
+      raise Foreman::Exception.new(N_("Unable to find template %s"), id) unless template&.persisted?
       template
     end
 
diff --git a/app/views/compute_resources_vms/form/libvirt/_base.html.erb b/app/views/compute_resources_vms/form/libvirt/_base.html.erb
index ff89e988221..ad88274d096 100644
--- a/app/views/compute_resources_vms/form/libvirt/_base.html.erb
+++ b/app/views/compute_resources_vms/form/libvirt/_base.html.erb
@@ -17,8 +17,6 @@
              { :disabled    => images.empty? || (params[:host] && params[:host][:provision_method] == 'build'),
                :'data-url'  => template_selected_compute_resource_path(compute_resource),
                :onchange    => 'tfm.computeResource.libvirt.imageSelected(this);',
-               :help_inline => :indicator,
-               :help_block  => _("Image to use"),
                :label => _('Image'), :label_size => "col-md-2"} %>
 </div>
 
diff --git a/webpack/assets/javascripts/compute_resource/libvirt.js b/webpack/assets/javascripts/compute_resource/libvirt.js
index d56714df610..842b1304f5a 100644
--- a/webpack/assets/javascripts/compute_resource/libvirt.js
+++ b/webpack/assets/javascripts/compute_resource/libvirt.js
@@ -4,9 +4,12 @@
 /* eslint-disable jquery/no-val */
 /* eslint-disable jquery/no-find */
 /* eslint-disable jquery/no-parent */
+/* eslint-disable jquery/no-text */
+/* eslint-disable jquery/no-class */
 
 import $ from 'jquery';
 import { showSpinner } from '../foreman_tools';
+import { translate as __ } from '../react_app/common/I18n';
 
 export function networkSelected(item) {
   const selected = $(item).val();
@@ -54,26 +57,43 @@ export function imageSelected(item) {
 
   if (template) {
     const url = $(item).attr('data-url');
+    // For some reason there are two help blocks
+    // so we need to select the correct one
+    const help = $('#image_selection .form-group > div > .help-block');
 
     showSpinner();
+
     $.ajax({
       type: 'post',
       url,
       data: `template_id=${template}`,
       success(result) {
-        const capacity = $('#storage_volumes')
-          .children('.fields')
-          .find('[id$=capacity]')[0];
-
-        if (
-          parseInt(capacity.value.slice(0, -1), 10) <
-          parseInt(result.capacity, 10)
-        ) {
-          capacity.value = `${result.capacity}G`;
+        help.empty();
+
+        const capacity = $(
+          '#host_compute_attributes_volumes_attributes_0_capacity'
+        );
+
+        const capacityInForm = parseInt(
+          capacity.attr('value').slice(0, -1),
+          10
+        );
+        const capacityFromImage = parseInt(result.capacity, capacityInForm);
+
+        if (capacityInForm < capacityFromImage) {
+          capacity.attr('value', `${capacityFromImage}G`);
         }
-        $('#storage_volumes')
-          .children('.fields')
-          .find('[id$=format_type]')[0].value = 'qcow2';
+
+        $('#storage_volumes .fields')
+          .find('#host_compute_attributes_volumes_attributes_0_format_type')
+          .select2('val', 'qcow2');
+      },
+      error() {
+        help.html(
+          $('<span />')
+            .addClass('text-danger')
+            .text(__('Image not found'))
+        );
       },
       complete() {
         // eslint-disable-next-line no-undef