Fixes #37767 - Fixes User search filter for 'auth_source_type'. #10293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manisha15
force-pushed
the
fix_user_search_filter
branch
from
57cecb7
to
c9de82b
Compare
Manisha15
force-pushed
the
fix_user_search_filter
branch
from
c9de82b
to
2c52b61
Compare
|
test failures are unrelated. |
|
Similar to foreman/app/models/concerns/taxonomix.rb Line 14 in 2ea2c46 foreman/app/models/concerns/taxonomix.rb Line 186 in 2ea2c46 Thanks @Manisha15 |
sbernhard
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If LDAP Authentication source is added in
Administer > Authentication Sourcesthen User search filter fails forauth_source_typeas it cannot find attributes to set default values for them. Since LDAP auth source is not initialized in User page it fails the condition set_defaults after initialize. To prevent this, set defaults only if its a new record and not when there already exists some AuthSourceLdap object.