Refs #36999 - Force host-passthrough CPU model for libvirt #10297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the :cpu option is not specified, fog-libvirt uses the default configured CPU model on the libvirt host. This is often qemu64 and that lacks some features you generally want. host-passthrough is recommended by libvirt so this opts into that. Technically it duplicates the default that fog-libvirt already sets, but if you leave the hash empty then it falls back to the host default. (cherry picked from commit 3b9957f)
pr-processor
bot
added
Not yet reviewed
Stable branch
ekohl
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the :cpu option is not specified, fog-libvirt uses the default configured CPU model on the libvirt host. This is often qemu64 and that lacks some features you generally want. host-passthrough is recommended by libvirt so this opts into that.
Technically it duplicates the default that fog-libvirt already sets, but if you leave the hash empty then it falls back to the host default.
(cherry picked from commit 3b9957f)