Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37805 - Add possibility to display message when table is empty #10316

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

kmalyjur
Copy link
Contributor

@kmalyjur kmalyjur commented Sep 11, 2024

Before:
image

After adding a custom message:
image
image

This PR is needed for Fixes #37630 - Display basic list of hosts on the new job_invocations page

@github-actions github-actions bot added the UI label Sep 11, 2024
@kmalyjur kmalyjur changed the title Add possibility to display message when table is empty Fixes #37805 - Add possibility to display message when table is empty Sep 11, 2024
Copy link
Member

@MariaAga MariaAga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@MariaAga MariaAga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt the test failures are related but I'll take a look

@MariaAga
Copy link
Member

Test failures unrelated. Also I ran the other js tests and they pass.

@MariaAga MariaAga merged commit 1a5c1b9 into theforeman:develop Sep 12, 2024
62 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants