Fixes #36518 - show disk/partitions of vsphere host #9740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36518 |
|
fog/fog-vsphere#284 was merged yesterday. |
ekohl
reviewed
Jun 26, 2023
...javascripts/react_app/components/HostDetails/Tabs/Details/Cards/Virtualization/VirtVmware.js
Outdated
Show resolved
Hide resolved
MariaAga
reviewed
Jun 28, 2023
...javascripts/react_app/components/HostDetails/Tabs/Details/Cards/Virtualization/VirtVmware.js
Show resolved
Hide resolved
MariaAga
reviewed
Jul 4, 2023
...javascripts/react_app/components/HostDetails/Tabs/Details/Cards/Virtualization/VirtVmware.js
Outdated
Show resolved
Hide resolved
|
@sbernhard I merged it and remembered I forgot to test it with fog-vsphere v3.6.0, and it breaks the vm card in host details page (legacy and new) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires fog/fog-vsphere#284