Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #36543 - open navigation items in new tab #9759

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Fixes #36543 - open navigation items in new tab #9759

merged 1 commit into from
Jul 3, 2023

Conversation

MariaAga
Copy link
Member

ctrl+click currently opens items only if they are in the third level ( for example "Report Templates" will open, but "All hosts" will not)

@theforeman-bot
Copy link
Member

Issues: #36543

@MariaAga MariaAga marked this pull request as draft June 28, 2023 11:22
@MariaAga
Copy link
Member Author

draft as this causes double navigation

@MariaAga MariaAga marked this pull request as ready for review June 28, 2023 11:32
@MariaAga
Copy link
Member Author

Fixed

ekohl
ekohl reviewed Jun 28, 2023
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Firefox you can also use middle mouse to open a new tab. The code suggests it would also work, but did you by any chance test that too?

@MariaAga
Copy link
Member Author

by mistake only checked middle key and not ctrl + click, which doesnt work, so I'll fix that and will make sure it works on firefox and chrome

@MariaAga
Copy link
Member Author

Should be good now, couldnt find a way without this workaround

@ofedoren
Copy link
Member

[test unit]
[test integration]

ofedoren
ofedoren approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @MariaAga, checked with Chrome and Firefox, middle button click and ctrl click both work and open a new tab for second level (all hosts) and third level (templates).

@ekohl ekohl merged commit df3a0b0 into theforeman:develop Jul 3, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

@ofedoren ofedoren ofedoren approved these changes

Assignees
No one assigned
Labels
UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MariaAga @theforeman-bot @ofedoren @ekohl