Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #36549 - params tab show buttons only with premissions #9762

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Fixes #36549 - params tab show buttons only with premissions #9762

merged 1 commit into from
Jun 29, 2023

Conversation

MariaAga
Copy link
Member

@MariaAga MariaAga commented Jun 29, 2023 •
edited
Loading

In host details, parameters tab, delete and new buttons were shown and enabled for users with no premissions

@theforeman-bot
Copy link
Member

Issues: #36549

ofedoren
ofedoren approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @MariaAga, LGTM and fixes the issue.

@ofedoren
Copy link
Member

Test failures are unrelated.

@ofedoren ofedoren merged commit ecb35f9 into theforeman:develop Jun 29, 2023
8 checks passed
@adamruzicka adamruzicka added the Needs cherrypick This should be cherrypicked to the stable branches or branches label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofedoren ofedoren ofedoren approved these changes

Assignees
No one assigned
Labels
Needs cherrypick This should be cherrypicked to the stable branches or branches UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MariaAga @theforeman-bot @ofedoren @adamruzicka