Refs #36575 - Avoid some translations during startup #9854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: c4bfd47 ("fixes theforeman#3725, theforeman#4167 - root password validations, remove default password")
Fixes: 9c30b63 ("fixes theforeman#6067 - UI inconsistency around root password limit 8 characters")
Fixes: 060d200 ("Fixes #20119 - Be more descriptive when validating hostname")
Fixes: 535d232 ("Fixes #14013 - add a setting for default owner of new hosts")
Fixes: 0351034 ("Fixes #13768 - random and MAC-based name generator")
String interpolation in translated strings should mostly be avoided. This rewrites it to have explicit definitions for both locations and organizations. Fixes: 9d3eace ("Fixes #10359 - API doc does mention org/loc in create/update")
Since b1b46b6 the labels are translated during initialization. This is because it uses () instead of N(). The latter only marks a string for translation. Doing this leads to infinite recursion while starting up when updating to fast_gettext 2.1+. It can also lead to other issues where a column can be translated multiple times. Fixes: b1b46b6 ("Fixes #35274 - Make columns on host index page selectable (theforeman#9319)")
|
[test katello] |
evgeni
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes some fixes from #9771 that are known to be correct and should be merged. It doesn't fully solve it, but it moves closer to the target.