Fix Rails/FindEach cop

theforeman · Jan 16, 2024 · 351bab4 · 351bab4
1 parent 16f4938
commit 351bab4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/app/controllers/api/v2/discovered_hosts_controller.rb b/app/controllers/api/v2/discovered_hosts_controller.rb
@@ -162,7 +162,7 @@ def auto_provision_all
 
         total_count = 0
         overall_errors = ""
-        Host::Discovered.all.each do |discovered_host|
+        Host::Discovered.all.find_each do |discovered_host|
           if rule = find_discovery_rule(discovered_host)
             result &= perform_auto_provision(discovered_host, rule)
             unless discovered_host.errors.empty?

diff --git a/db/migrate/20141223142759_fill_discovery_attribute_sets_for_existing_hosts.rb b/db/migrate/20141223142759_fill_discovery_attribute_sets_for_existing_hosts.rb
@@ -4,7 +4,7 @@ class FakeDiscoveredHost < ApplicationRecord
 
 class FillDiscoveryAttributeSetsForExistingHosts < ActiveRecord::Migration[4.2]
   def up
-    FakeDiscoveredHost.where(:type => "Host::Discovered").all.each do |host|
+    FakeDiscoveredHost.where(:type => "Host::Discovered").all.find_each do |host|
       begin
         say "Populating attribute set for discovered host #{host.name}"
         ForemanDiscovery::ImportHooks::DiscoveryAttribute.new(host: host, facts: host.facts_hash).after_populate

diff --git a/db/migrate/20150512150432_remove_old_discovery_reader_permissions.rb b/db/migrate/20150512150432_remove_old_discovery_reader_permissions.rb
@@ -1,6 +1,6 @@
 class RemoveOldDiscoveryReaderPermissions < ActiveRecord::Migration[4.2]
   def up
-    Permission.where("name like '%_discovery_rules' and resource_type is null").each do |permission|
+    Permission.where("name like '%_discovery_rules' and resource_type is null").find_each do |permission|
       permission.update(:resource_type => 'DiscoveryRule')
     end
   end