-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #37068 - fix redirect after provisioning discovered host #616
Conversation
@nofaralfasi Related failed tests:
This one is failing all the time, I need to take a look at it:
|
Can you please rebase? The other failing test has been fixed |
@@ -83,7 +83,8 @@ def perform_update(host, success_message = nil) | |||
::ForemanDiscovery::HostConverter.set_build_clean_facts(host) | |||
::ForemanDiscovery::HostConverter.unused_ip_for_host(host) | |||
if host.save | |||
success_options = { :success_redirect => host_path(host), :redirect_xhr => request.xhr? } | |||
host_path = Setting['host_details_ui'] ? helpers.host_details_page_path(host) : host_path(host) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
host_path = Setting['host_details_ui'] ? helpers.host_details_page_path(host) : host_path(host) | |
host_path = Setting['host_details_ui'] ? host_details_page_path(host) : host_path(host) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, otherwise works as expected
Redirect to the correct page after provisioning discovered hosts, based on user settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍏 LGTM
Failing tests are not related, fixed in #619
Redirect to the correct page after provisioning discovered hosts, based on user settings.