Fix menu item integration test #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Foreman 2.0 there has been a UserMenu service that provides the entire user menu. At some point the UI also changed to retrieve this dynamically rather than include it in the actual HTML. This rewrites the test to use the service, rather than testing the base template indirectly.
Merged
|
And I also added a commit that I think fixes the Jenkins tests, just because I want to see everything green now. |
The "unit" tests also include system tests.
stejskalleos
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Foreman 2.0 there has been a UserMenu service that provides the entire user menu. At some point the UI also changed to retrieve this dynamically rather than include it in the actual HTML. This rewrites the test to use the service, rather than testing the base template indirectly.