Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shared GitHub Actions workflow for ruby #180

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Conversation

ofedoren
Copy link
Member

No description provided.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no rubocop task in the Rakefile:

Run if [ -f Rakefile ] ; then
rake aborted!
Don't know how to build task 'rubocop' (See the list of available tasks with `rake --tasks`)

I raised it before, but should we start assuming Rubocop as an executable exists and always use that?

@ekohl
Copy link
Member

ekohl commented Jan 12, 2024

@ekohl
Copy link
Member

ekohl commented Jan 23, 2024

@ofedoren looks like there are RuboCop failures. Mind taking a look?

@archanaserver
Copy link
Contributor

@ekohl i'll take a look and raise a PR with the rubocop fix here

@archanaserver
Copy link
Contributor

This should fix it now: #182

@ofedoren
Copy link
Member Author

ofedoren commented Jan 26, 2024

I've fixed rubocop here, but the tests are now red due to webpack changes. I'm not so sure how to fix it though.

@MariaAga, sorry for bothering you, I think you already work on that, but just to make sure: should we wait a bit or should we (I mean plugin maintainers) do something to fix the issues?

@MariaAga
Copy link
Member

Could you change css files to:

 - @import '~@theforeman/vendor/scss/variables';
+ @import 'node_modules/@theforeman/vendor/scss/variables.scss';

Its failing tests without it and its not a priority to investigate right now as its only a test issue

@ofedoren ofedoren merged commit d307b43 into theforeman:master Jan 29, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants