-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shared GitHub Actions workflow for ruby #180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no rubocop task in the Rakefile:
Run if [ -f Rakefile ] ; then
rake aborted!
Don't know how to build task 'rubocop' (See the list of available tasks with `rake --tasks`)
I raised it before, but should we start assuming Rubocop as an executable exists and always use that?
https://github.com/theforeman/foreman_webhooks/pull/71/files#r1450828173 is also an option. |
@ofedoren looks like there are RuboCop failures. Mind taking a look? |
@ekohl i'll take a look and raise a PR with the rubocop fix here |
This should fix it now: #182 |
I've fixed rubocop here, but the tests are now red due to webpack changes. I'm not so sure how to fix it though. @MariaAga, sorry for bothering you, I think you already work on that, but just to make sure: should we wait a bit or should we (I mean plugin maintainers) do something to fix the issues? |
Could you change css files to:
Its failing tests without it and its not a priority to investigate right now as its only a test issue |
No description provided.