Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Rubocop rules #182

Closed
wants to merge 3 commits into from
Closed

Fix Rubocop rules #182

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0c3fa1
Fix Minitest/RefuteIncludes cop
archanaserver Jan 26, 2024
101e27b
Fix Minitest/AssertIncludes cop
archanaserver Jan 26, 2024
283964b
Fix Layout/ExtraSpacing cop
archanaserver Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,12 @@ Metrics:
Lint/UnusedMethodArgument:
Enabled: false

Lint/ConstantDefinitionInBlock:
Enabled: false

Layout/ExtraSpacing:
Enabled: true

# JobTemplates use this for inputs, we should probably whitelist classes
Security/YAMLLoad:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be an issue with Ruby 3 where load became safe_load.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekohl what is this about? could you please brief more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.rubocop.org/rubocop/cops_security.html#securityyamlload already has a note. Looks like it's Ruby 3.1, not 3.0.

Enabled: false
Expand Down