Use a more effective method of counting

This saves an intermediate array.
theforeman · Oct 28, 2022 · de30b20 · de30b20
1 parent e6c212a
commit de30b20
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/files/report.rb b/files/report.rb
@@ -126,7 +126,7 @@ def metrics_to_hash(report)
       report_status["failed"] += 1
     end
     # fix for Puppet non-resource errors (i.e. failed catalog fetches before falling back to cache)
-    report_status["failed"] += report.logs.find_all {|l| l.source =~ /Puppet$/ && l.level.to_s == 'err' }.count
+    report_status["failed"] += report.logs.count {|l| l.source =~ /Puppet$/ && l.level.to_s == 'err' }
 
     return report_status
   end