Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banch of fixes #154

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Serhii-Slutskyi
Copy link

@Serhii-Slutskyi Serhii-Slutskyi commented Sep 27, 2020

I wanted to use this library, but when I installed it, I had a lot of problems

  • Picker was deprecated from react-native core repository
    This pull was fixed picker problem, and I only added to readme that picker should be installed from @react-native-community/picker

  • Some components have an issues with Maximum update depth exceeded...

to fix this issue update lib/countryPicker.js:

componentDidUpdate() {
    if(this.props.selectedCountry !== this.state.selectedCountry) {
      this.setState({
        selectedCountry: this.props.selectedCountry,
      });
    }
  }
  • Also the core ability to use of library is to use countries and get dialCode on input wasn't worked

So I reworked it, added ability to use Country code or not via prop useCountryCode

@bbaappss
Copy link

Thanks for writing this, the package it at least working now!

@ravi-poonia
Copy link

Thx man, merged it into my fork and a bunch of other PRs as well. I'm thinking of maintaining that from now on. Will you be interested in helping out?

@zizzle6717
Copy link

zizzle6717 commented Dec 27, 2020

@ravi-poonia Is your fork published? I would be happy to help out. I don't think the current maintainer will revisit this repo at all.

@zizzle6717
Copy link

I have published v1.0.0 and converted the source to typescript. Let me know if there is anything I can do to improve the change request process. Please submit new pull requests as the package as been more to https://github.com/rili-live/react-native-phone-input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants