Skip to content

Commit

Permalink
fix: replace webpack-favicons dep by maintained favicons-webpack-plug…
Browse files Browse the repository at this point in the history
…in (#467)
  • Loading branch information
xoxys authored Dec 2, 2023
1 parent 45398ae commit e931dae
Show file tree
Hide file tree
Showing 3 changed files with 67 additions and 206 deletions.
241 changes: 50 additions & 191 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
"eslint-config-prettier": "9.0.0",
"eslint-plugin-prettier": "5.0.1",
"favicons": "7.1.4",
"favicons-webpack-plugin": "6.0.1",
"npm-run-all": "4.1.5",
"postcss-loader": "7.3.3",
"prettier": "3.1.0",
Expand All @@ -56,7 +57,6 @@
"svgtofont": "4.0.1",
"webpack": "5.89.0",
"webpack-cli": "5.1.4",
"webpack-favicons": "1.3.8",
"webpack-manifest-plugin": "5.0.0",
"webpack-remove-empty-scripts": "1.0.4"
},
Expand Down
30 changes: 16 additions & 14 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const glob = require("glob")

const { WebpackManifestPlugin } = require("webpack-manifest-plugin")
const GitVersionPlugin = require("@eloquent/git-version-webpack-plugin")
const WebpackFavicons = require("webpack-favicons")
const FaviconsWebpackPlugin = require("favicons-webpack-plugin")
const RemoveEmptyScriptsPlugin = require("webpack-remove-empty-scripts")
const CopyPlugin = require("copy-webpack-plugin")
const SRIPlugin = require("./webpack.plugins")
Expand Down Expand Up @@ -56,19 +56,21 @@ var config = {
]
}),

new WebpackFavicons({
src: path.resolve("src", "static", "favicon", "favicon.svg"),
path: "favicon/",
background: "#efefef",
theme_color: "#efefef",
icons: {
android: { offset: 10 },
appleIcon: { offset: 10 },
appleStartup: { offset: 10 },
favicons: true,
windows: { offset: 10 },
yandex: false,
coast: false
new FaviconsWebpackPlugin({
logo: path.resolve("src", "static", "favicon", "favicon.svg"),
prefix: "favicon/",
inject: false,
favicons: {
background: "#efefef",
theme_color: "#efefef",
icons: {
android: { offset: 10 },
appleIcon: { offset: 10 },
appleStartup: { offset: 10 },
favicons: true,
windows: { offset: 10 },
yandex: false
}
}
}),

Expand Down

0 comments on commit e931dae

Please sign in to comment.