Skip to content

Commit

Permalink
chore(Android) Set compileSdkVersion to 34
Browse files Browse the repository at this point in the history
  • Loading branch information
guillaume-tgl committed Nov 3, 2023
1 parent 96c58ca commit 42848cc
Show file tree
Hide file tree
Showing 9 changed files with 18 additions and 18 deletions.
5 changes: 2 additions & 3 deletions android/gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#Fri Sep 10 13:50:13 CEST 2021
distributionBase=GRADLE_USER_HOME
distributionUrl=https\://services.gradle.org/distributions/gradle-7.0.2-bin.zip
distributionPath=wrapper/dists
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
1 change: 1 addition & 0 deletions cordova-plugin-genius-scan-demo/config.xml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
<resource-file src="res/android/ic_launcher_foreground.xml" target="/app/src/main/res/drawable/ic_launcher_foreground.xml" />
<resource-file src="res/android/ic_launcher.xml" target="/app/src/main/res/mipmap-anydpi-v26/ic_launcher.xml" />
<preference name="AndroidXEnabled" value="true" />
<preference name="android-compileSdkVersion" value="34" />
</platform>
<engine name="ios" spec="~7.0.1" />
<engine name="android" spec="~12.0.0" />
Expand Down
4 changes: 2 additions & 2 deletions flutter-plugin-genius-scan-demo/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ apply plugin: 'com.android.application'
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"

android {
compileSdkVersion 33
compileSdkVersion 34

lintOptions {
disable 'InvalidPackage'
Expand All @@ -34,7 +34,7 @@ android {
defaultConfig {
applicationId "com.geniusscansdk.flutter.demo"
minSdkVersion 21
targetSdkVersion 33
targetSdkVersion 34
versionCode flutterVersionCode.toInteger()
versionName flutterVersionName
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
Expand Down
2 changes: 1 addition & 1 deletion flutter-plugin-genius-scan-demo/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ buildscript {
}

dependencies {
classpath 'com.android.tools.build:gradle:7.0.3'
classpath 'com.android.tools.build:gradle:7.4.2'
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.3-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-all.zip
3 changes: 2 additions & 1 deletion flutter-plugin-genius-scan-demo/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ packages:
dependency: "direct main"
description:
name: flutter_genius_scan
url: "https://pub.dartlang.org"
sha256: "9e2d79561172af2608fbfd0fe7414e8ae3166c1e08375cb8400c4be3c648d90a"
url: "https://pub.dev"
source: hosted
version: "4.15.0"
flutter_test:
Expand Down
6 changes: 3 additions & 3 deletions react-native-genius-scan-demo/README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Genius Scan SDK for React Native demo

## Installation
If you don't have it already, install react native CLI
If you don't have it already, install the ReactNative CLI
```
npm install -g react-native-cli
```
Expand All @@ -17,6 +17,6 @@ For iOS, run the command `pod install` from the `ios` folder.

Run the app in a simulator or on a phone
```
react-native run-ios
react-native run-android
npx react-native run-ios
npx react-native run-android
```
5 changes: 2 additions & 3 deletions react-native-genius-scan-demo/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@

buildscript {
ext {
buildToolsVersion = "33.0.0"
minSdkVersion = 21
compileSdkVersion = 33
targetSdkVersion = 33
compileSdkVersion = 34
targetSdkVersion = 34

ndkVersion = "25.1.8937393"
}
Expand Down
8 changes: 4 additions & 4 deletions react-native-genius-scan-demo/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 42848cc

Please sign in to comment.