Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build and split macros and plugin. #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix build and split macros and plugin. #8

wants to merge 2 commits into from

Conversation

jeff-davis
Copy link

No description provided.

This is to avoid mixing a plugin with normal macros.
@stereobooster
Copy link
Contributor

current master

rustc --version
rustc 1.12.0-nightly (5e18b4bad 2016-07-08)
(3ff8369) cargo build
   Compiling postgres_extension v0.0.1 (postgres-extension.rs)
src/lib.rs:11:1: 11:30 warning: type `fmNodePtr` should have a camel case name such as `Fmnodeptr`, #[warn(non_camel_case_types)] on by default
src/lib.rs:11 type fmNodePtr = *mut c_void;
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/lib.rs:12:1: 12:32 warning: type `fmAggrefPtr` should have a camel case name such as `Fmaggrefptr`, #[warn(non_camel_case_types)] on by default
src/lib.rs:12 type fmAggrefPtr = *mut c_void;
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/lib.rs:73:14: 73:20 warning: private trait in public interface (error E0445), #[warn(private_in_public)] on by default
src/lib.rs:73     where T: PgType {
                           ^~~~~~
src/lib.rs:73:14: 73:20 warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
src/lib.rs:73:14: 73:20 note: for more information, see the explanation for E0446 (`--explain E0446`)
src/lib.rs:461:5: 461:35 warning: struct field is never used: `ptr`, #[warn(dead_code)] on by default
src/lib.rs:461     ptr: *mut FunctionCallInfoData,
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/lib.rs:469:5: 469:15 warning: struct field is never used: `val`, #[warn(dead_code)] on by default
src/lib.rs:469     val: usize
                   ^~~~~~~~~~
src/lib.rs:473:20: 473:25 warning: unused variable: `value`, #[warn(unused_variables)] on by default
src/lib.rs:473     pub fn new_str(value: &str) -> Datum {
                                  ^~~~~

vs this branch

rustc --version
rustc 1.12.0-nightly (5e18b4bad 2016-07-08)
(5b36517) cargo build
   Compiling postgres_extension v0.0.1 (postgres-extension.rs)
rustc --version
rustc 1.10.0 (cfcb716cf 2016-07-03)
(5b36517) cargo build
   Compiling libc v0.2.13
   Compiling postgres_extension v0.0.1 (postgres-extension.rs)

stereobooster added a commit to stereobooster/pgxn-utils that referenced this pull request Jul 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants